NickAkhmetov/HMP-549 Revise to use assaytype endpoint #3361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAkhmetov
changed the title
NickAkhmetov
commented
Jan 2, 2024
There was a problem hiding this comment.
I adjusted the spacing of the commented out endpoints so they're all aligned with the USER_TEMPLATES_ENDPOINT - this was purely an aesthetic change. The meaningful additions are the different SOFT_ASSAY_ENDPOINT values for the TEST, DEV and PROD environments and the removal of the TYPE_SERVICE values.
lchoy
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the generation of vitessce visualizations to be done using the
assaytypeendpoint instead of the deprecated TypeClient.The
SOFT_ASSAY_ENDPOINTenvironment variable has been added to configs by Zhou. Since it is a part of the ingest-api, I've adjusted the service status table to display the ingest API URL in use by trimming the/assaytypesuffix from the soft assay endpoint.TODO:
Remove type service env variables and add assaytype endpoint env variableTroubleshoot seqfish datasets only displaying descendant pyramidsUpdate portal-visualization version