-
Notifications
You must be signed in to change notification settings - Fork 18
Fix job status 'broken' with slurm when job is in fact not broken #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's with the |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| experiments: | ||
| - name: slow | ||
| args: [python, 'slow.py', '@EXTRA_ARGS@'] | ||
| stdout: out | ||
|
|
||
| instances: | ||
| - repo: local | ||
| items: | ||
| - name: bar | ||
| files: [] | ||
| extra_args: [] | ||
|
|
||
| variants: | ||
| - axis: 'foo' | ||
| items: | ||
| - name: '1' | ||
| extra_args: ['1'] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # Test setup for PR #183 | ||
| Issue: `simex e list` lists experiments as 'broken' even though they are running fine in slurm. | ||
| We currently do not have integration tests in simex - but: we can use the experiment setup in this folder manually to test for this bug and similar problems if the need arises. | ||
| Usage: just run `runtest.sh` and confirm that the output has correct status (i.e. not 'broken') |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| simex e purge --failed -f | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps use an interpreter line here?: #!/bin/bash |
||
|
|
||
| rm -r output | ||
| rm -r aux | ||
| rm .simex.cache | ||
|
|
||
| simex e list | ||
| simex e launch --launcher scaling | ||
| simex e list | ||
|
|
||
| squeue | ||
| squeue -r | ||
|
|
||
| sleep 3s | ||
|
|
||
| simex e list | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import time | ||
|
|
||
| time.sleep(20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this require that
len(output) >= 2?