Fix job status 'broken' with slurm when job is in fact not broken #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-bebop
requested changes
Apr 29, 2025
Collaborator
c-bebop
left a comment
c-bebop
left a comment
There was a problem hiding this comment.
Looks good, just needs some adaptation/safety check.
| for entry in output: | ||
| entry_jobid = entry[0] | ||
| entry_state = entry[4] | ||
| entry_state = entry[1] |
Collaborator
There was a problem hiding this comment.
Doesn't this require that len(output) >= 2?
| @@ -0,0 +1,16 @@ | |||
| simex e purge --failed -f | |||
Collaborator
There was a problem hiding this comment.
Perhaps use an interpreter line here?:
#!/bin/bash
Collaborator
There was a problem hiding this comment.
What's with the tests/examples/slurm-pr-183 folder structure? Do you want to leave it as this? Or what would be the actual folder you want to put this in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is caused by job names with spaces in them - in that case output parsing was wrong. Fixed by just not querying for the name since it is not used at all.