fix: add type_name filter for event log filters #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are the tests stable for you? Locally, most of the tests are pretty unstable for me so that there's one of them failing on current main most of the time... |
|
One issue is #42 but the projection test is also pretty unstable with a different kind of error. |
To avoid mistaking events for one entity as another type
jrudolph
force-pushed
the
fix/do-not-attempt-to-load-entity-with-wrong-type
branch
from
b107fee to
096c557
Compare
|
I fixed the test issues and added a small addition to a test case that shows the problem. |
|
Thanks a lot! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid mistaking events for one entity as another type
Refs #31
(still needs tests)