-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide whether ids need to be globally unique or not #31
Comments
Hmm ... so change |
Yes that, and also add an extra constraint on the type to all queries. |
I actually already ran into this problem because you can just load the entity of a certain id with the wrong entity type and it will happily recover that entity (which somewhat likely fails during deserializing the wrong event types but might not depending on lucky circumstances). |
Done in #38. |
Since all entities share the same entity log, right now entity ids need to be unique across all entity types. Either the queries could be improved not to make this assumption (add another WHERE clause everywhere) or this assumption needs to be documented.
The text was updated successfully, but these errors were encountered: