forked from hlxsites/merative
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce cls caused by nav #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks @fkakatie ! @helms-charity please take a look and merge when you have a moment. |
amol-anand
approved these changes
Apr 15, 2024
helms-charity
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the fix, looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, all
header
height styles are located inblock/header/header.css
, which is lazy-loaded. This generates significant CLS when the loaded content inmain
is shoved down to accommodate the newly loaded stylesheets impactingheader
andnav
. Proposing to moveheader nav
styles impacting height intostyles.css
so circumvent this issue. Also proposing the removal of duplicative styles.Changed
header nav
andmain
height set instyles.css
, rather than in the lazy-loaded header blockRemoved
Test URLs
main
): main--merative2--hlxsites.hlx.pagemain
): main--merative2--hlxsites.hlx.page/clinical-developmentmain
): main--merative2--hlxsites.hlx.page/blog