Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

379-revert some of PR 378 CSS #380

Merged
merged 4 commits into from
Apr 25, 2024
Merged

379-revert some of PR 378 CSS #380

merged 4 commits into from
Apr 25, 2024

Conversation

helms-charity
Copy link
Collaborator

@helms-charity helms-charity commented Apr 25, 2024

Issue - solution-header had regressions in the sticky design due to code cleaning done via PR #378. This reverts some of those changes.

Fixes #379

Test URLs

Testing Instruction

NOTE: This PR also fixes problem of some content overlapping the sticky (black) solutions-header

image

Copy link

aem-code-sync bot commented Apr 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 25, 2024

@aem-code-sync aem-code-sync bot temporarily deployed to 379-solutionshead April 25, 2024 12:24 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 379-solutionshead April 25, 2024 13:03 Inactive
Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Tested and I'm not seeing the navigation issues anymore.

@helms-charity helms-charity merged commit dff051e into main Apr 25, 2024
2 checks passed
@helms-charity helms-charity deleted the 379-solutionshead branch April 25, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: solutions nav height regression
2 participants