Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
========================================
+ Coverage 7.86% 8.49% +0.62%
========================================
Files 124 124
Lines 17470 17448 -22
Branches 381 379 -2
========================================
+ Hits 1374 1482 +108
+ Misses 16085 15950 -135
- Partials 11 16 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3b51380 to
2dfc4d2
Compare
|
@anthonyduong9 thanks for the update, sorry for slowness on getting around to it! we need test(s) that the before/after results are the same before merging this - can you write them, or let me know what info you'd need to write them? if you don't have time for it lmk - i can work on it. |
989a1f3 to
a3c2ed0
Compare
a3c2ed0 to
9c7f58b
Compare
|
@hijohnnylin I've added tests for |
Problem
all.pyandsingle.pyboth contain functions_get_safe_dtype()and_safe_cast()all.pyandsingle.pyduplicateget_layer_num_from_sae_id()all.pyandsingle.py, and so it seems unlikely we'll want to change it in two places.Fix
_get_safe_dtype()and_safe_cast()toshared.pyand deleting the other pair.get_layer_num_from_sae_id()toshared.py.calculate_per_source_dfa().Testing
make check-ci.