Skip to content

dedupe get_activations_by_index()#80

Open
anthonyduong9 wants to merge 1 commit intodedupe-code-in-all-and-singlefrom
dedupe-get_activations_by_index
Open

dedupe get_activations_by_index()#80
anthonyduong9 wants to merge 1 commit intodedupe-code-in-all-and-singlefrom
dedupe-get_activations_by_index

Conversation

@anthonyduong9
Copy link
Contributor

@anthonyduong9 anthonyduong9 commented Apr 25, 2025

Problem

get_activations_by_index() has been duplicated in all.py.

Fix

Moving get_activations_by_index() to shared.py.

Testing

  • I compared code I thought to be duplicated at www.diffchecker.com.
  • From apps/inference, I ran make check-ci.

Depends on #76

@anthonyduong9 anthonyduong9 force-pushed the dedupe-code-in-all-and-single branch from 3b51380 to 2dfc4d2 Compare May 7, 2025 01:28
@anthonyduong9 anthonyduong9 force-pushed the dedupe-get_activations_by_index branch from 0d684fb to bf93f2b Compare May 7, 2025 01:33
@anthonyduong9 anthonyduong9 force-pushed the dedupe-code-in-all-and-single branch from 989a1f3 to a3c2ed0 Compare July 21, 2025 04:11
@anthonyduong9 anthonyduong9 force-pushed the dedupe-code-in-all-and-single branch from a3c2ed0 to 9c7f58b Compare August 14, 2025 00:24
@anthonyduong9 anthonyduong9 force-pushed the dedupe-get_activations_by_index branch from bf93f2b to 78a245e Compare August 14, 2025 02:45
@anthonyduong9 anthonyduong9 marked this pull request as ready for review August 14, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant