Skip to content

Feature/hip1190 sign transactions #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omar-hgraph wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Feature/hip1190 sign transactions #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c8fb045
feat(hip-1190): add signTransactions support to V1 and V2 hooks
omar-hgraph Nov 23, 2025
f8bd79e
feat(hip-1190): add UI for multi-node transaction signing
omar-hgraph Nov 23, 2025
9022da8
fix: add null safety checks for utility functions
omar-hgraph Nov 23, 2025
18979e7
refactor: clean up provider configuration and add onProgress parameter
omar-hgraph Nov 23, 2025
3f54d87
build: use local hedera-wallet-connect dependency
omar-hgraph Nov 23, 2025
acdd94c
feat(hedera-app): add HIP-1190 execution with failover and execution …
omar-hgraph Nov 27, 2025
02da0c6
feat(hip1190/v1): Add signature extraction and per-node tracking for …
omar-hgraph Nov 30, 2025
34c45f9
fix: Replace 'any' types with proper TypeScript types for ESLint comp…
omar-hgraph Dec 2, 2025
c3b2ec4
refactor: Remove pre-build scripts for hedera-wallet-connect from pac…
omar-hgraph Dec 2, 2025
9b2f35a
fix: Resolve TypeScript build errors for HIP-1190 implementation
omar-hgraph Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6,732 changes: 4,144 additions & 2,588 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"test": "npm run build && vitest run --coverage"
},
"dependencies": {
"@hashgraph/hedera-wallet-connect": "2.0.4-canary.3ca04e9.0",
"@hashgraph/hedera-wallet-connect": "file:../hedera-wallet-connect",
"@hashgraph/sdk": "^2.72.0",
"@reown/appkit": "^1.8.4",
"@reown/appkit-adapter-ethers": "^1.8.4",
Expand Down
2 changes: 2 additions & 0 deletions src/V1App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export function V1App() {

// V1 connection state
const v1Connection = useDAppConnectorV1()

const v1Methods = useV1Methods(
v1Connection.signers,
v1Connection.connector,
Expand All @@ -45,6 +46,7 @@ export function V1App() {
setNodes,
signedTransaction,
setSignedTransaction,
undefined, // onProgress - handled by MethodExecutor
)

// Get configuration from localStorage
Expand Down
13 changes: 10 additions & 3 deletions src/V2App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
HederaProvider,
HederaAdapter,
hederaNamespace,
} from '@hashgraph/hedera-wallet-connect'

Check failure on line 17 in src/V2App.tsx

View workflow job for this annotation

GitHub Actions / build 

Cannot find module '@hashgraph/hedera-wallet-connect' or its corresponding type declarations.
import { JsonRpcProvider } from 'ethers'
import { metadata, networks, DEFAULT_RPC_URL } from './config'
import { ConfigurationModal } from './components/ConfigurationModal'
Expand Down Expand Up @@ -70,7 +70,6 @@
const providerOpts = {
projectId,
metadata,
logger: 'error' as const,
optionalNamespaces: {
// hashpack only uses the first namespace in the list
eip155: {
Expand Down Expand Up @@ -110,8 +109,6 @@

createAppKit({
adapters: [nativeHederaAdapter, eip155HederaAdapter],
logger: 'error' as const,
// @ts-expect-error universalProvider type compatibility
universalProvider,
projectId,
metadata,
Expand Down Expand Up @@ -201,12 +198,22 @@
: undefined

// Setup Hedera methods
// Create signer for HIP-1190 signTransactions method
const hederaSigner =
appKitConfig?.universalProvider?.session && hederaAccount
? appKitConfig.universalProvider.nativeProvider?.getSigner(
appKitConfig.universalProvider.session.topic,
)
: undefined

const { executeHederaMethod } = useHederaMethods(
appKitConfig?.universalProvider || ({} as HederaProvider),
hederaAccount || '',
setTransactionId,
setSignedMsg,
setNodes,
undefined, // onProgress - handled by MethodExecutor
hederaSigner,
)

// Setup Ethereum methods
Expand Down
Loading
Loading