Feature/hip1190 sign transactions #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement hedera_signTransactions method execution in both DAppConnector (V1) and Reown AppKit (V2) integration paths. Changes: - Fix HederaSignTransactionsParams interface (recipientId → to) - Add AccountId import for parameter conversion - Extract and display unique signatures for each node - Format result with per-node signature details
Add HIP-1190 method configuration with dynamic node count selector (1-10 nodes). Enhance result display to show per-node signatures. Changes: - Add nodeCount parameter with options: 1, 3, 5 (default), 7, 10 - Format multi-node results with summary and expandable details - Add TransactionProgressModal component (not yet wired)
Add defensive null checks to prevent runtime errors when optional parameters are undefined. Changes: - toEvmAddress: return empty string if accountId is null/undefined - personal_sign: use optional chaining for message.startsWith check
Remove logger configuration from V2 AppKit setup and add onProgress parameter to hook calls for future progress tracking support. Changes: - Remove redundant logger options from provider and AppKit configs - Add undefined onProgress parameter to V1 and V2 method hooks - Minor formatting cleanup
Switch to file link for active HIP-1190 development. Add pre-build scripts to ensure wallet-connect is built before dev/build/test. Changes: - Update dependency: @hashgraph/hedera-wallet-connect 2.0.4-canary → file:../ - Add predev, prebuild, pretest scripts to auto-build wallet-connect
…strategies - Implement complete PHASE 2: execution with automatic failover - Add executionStrategy parameter: 'firstSuccess' (production) vs 'allNodes' (testing) - Extract and report all signatures with public keys - Add performance metrics: signingDuration, totalDuration, per-node duration - Return actual Hedera transaction IDs and nodeIndexUsed - Include comprehensive per-node attempt details with success/failure status - Update MethodExecutor UI with execution strategy selection dropdown
…feature parity - Add allSignatures extraction with publicKeyPrefix and signature hex reporting - Implement per-node ID tracking in execution attempts array - Add nodeId and transactionId fields to each attempt record - Update both execution strategy return statements with allSignatures - Add executionStrategy parameter to type definitions - Achieve full feature parity between V1 and V2
- Add missing 'error' property to attempt type definition in MethodExecutor - Remove explicit type annotation for protoTx parameter to let TypeScript infer from ISignedTransaction - Fixes compatibility with Hedera SDK's ISignedTransaction and ISignatureMap types Resolves TypeScript errors: - TS2339: Property 'error' does not exist on attempt type - TS2345: Type incompatibility between custom type and ISignedTransaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIP-1190: Multi-Node Transaction Signing UI & Testing
Overview
Complete UI implementation and testing infrastructure for HIP-1190 multi-node transaction signing with automatic failover, execution strategies, and comprehensive metrics.
Key Features
firstSuccess: Production mode (stop on first success)allNodes: Testing mode (try all nodes, gather complete metrics)Implementation Details
HIP-1190 Method Support (commit c8fb045)
signTransactionsmethod to both V1 and V2 hooksUI Components (commit f8bd79e)
TransactionProgressModalcomponent for future progress trackingMethodExecutorcomponentExecution Engine (commit acdd94c)
executionStrategyparameter with UI selectionnodeIndexUsedindicating which node succeededMetrics & Tracking (commit 02da0c6)
Developer Experience (commits 3f54d87, 18979e7, 9022da8)
Testing Capabilities