Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ci fix android #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Ci fix android #194
Changes from 62 commits
0f63ab6a056c7896e1809934e0461866f2ccd668376bab1f48862f71e0bbab5619ccdc20eb56ea441a2a68db8fc422d4b2d8371fd705fcaefbc18a24c73ce9a94be7394960e2e3a9cf51dd30cbfa27dad57c0ea154125dc65ead397d88430f9b82c91d994ecd41c4af7889bab83394dd9377f2756981338d3de9f0fd10148c153d8f8125023ec779dcb375e70c8ab0c6f18051bcea4a924f09a3531b420eb51a78914e0c9dec1c94983cc75eec2d04fa44897bc589bdf3c27e06562040f342d8a326c2333ca5fb35b3cc6e8862ed3db16e457d86ebf56b24cd40047170a8228b6d6e0b9c39bbf7043fb6a578647a0a6deab7d7ac2ec346da0e897c26e762b71248a31b3af9a2a2ecad257ec1d8993acfe880d99f00433ebacdb64e533780724be85f0d3c9b6b8a53097fe12a95c44dcfdf17e89013b27a875fe2a2ad9a97d9b408faFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pin this third-party action to commit SHA pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@novabyte Wondering about licensing implications of this. The runner itself is Apache-2, but the sdk it pulls, especially the google_apis bit might be subject to stricter licensing?
Did we encounter something like this in the past and is this something we'd want to consider?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this
test-androidtask defined?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is line 65 in Taskfile
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.