Improving memory managemenet, testing and adding Justfile#1
Open
Improving memory managemenet, testing and adding Justfile#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to testing, memory management, and developer tooling for the
herdproject. It adds comprehensive unit, integration, and proxy tests, implements configurable memory limits for worker processes, and provides a Justfile for streamlined development workflows. The changes enhance code reliability, test coverage, and operational safety.Testing Enhancements:
ProcessFactoryand worker behavior, covering process spawning, health checks, timeout handling, memory limits, and process cleanup (factory_test.go,worker_test.go). [1] [2]integration_test.go).proxy/proxy_test.go).Memory Management:
WithMemoryLimitinProcessFactory, allowing a soft virtual memory limit to be set for worker processes (enforced viaulimiton Linux, no-op on macOS/unsupported platforms). Updated process spawning logic to use a shell wrapper when memory limits are specified (factory.go,examples/ollama/main.go). [1] [2] [3] [4]Developer Tooling:
justfilewith recipes for running tests (including race detection), linting, dependency tidying, coverage reporting, and a CI shortcut, improving developer experience and CI/CD integration.