Upgrade Helpy to Rails 5.0.7.2 and Ruby 2.6.10 #2085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a devcontainer to make development and contribution easier. The devcontainer is based on the Docker production image with the exception that it uses puma as instead of nginx. I needed to pin some of the gems that were being used in development as they were causing issues. Those gems were byebug pry-byebug rubocop
Key changes: Merged the onboarding and imap plugins into main Removed the slack plugin from Docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrade the entire Helpy core application to Rails 5.0.7.2 and Ruby 2.6.10.
Very minimal modification to the Helpy core application were made to achieve this as I wanted this to be an inplace upgrade to any existing installation.
All tests are passing green and all warnings have been eliminated.