upgrade to ruby 2.6.10 and Rails 5.0.7.2

Key changes:

Merged the onboarding and imap plugins into main
Removed the slack plugin from Docker

Author: rip747

.devcontainer/Dockerfile

@@ -1,7 +1,9 @@
 # Make sure RUBY_VERSION matches the Ruby version in .ruby-version
 #ARG RUBY_VERSION=3.3.3
 #FROM ghcr.io/rails/devcontainer/images/ruby:$RUBY_VERSION
-FROM ruby:2.5
+# you can find a specific ruby version at
+# https://hub.docker.com/_/ruby/tags
+FROM ruby:2.6.10
 
 #RUN curl -sL https://deb.nodesource.com/setup_16.x | bash -
 #RUN apt-get install nodejs -y
@@ -18,4 +20,12 @@ RUN apt-get update \
 ENV CHROME_VERSION=114.0.5735.90-1
 RUN wget -q https://mirror.cs.uchicago.edu/google-chrome/pool/main/g/google-chrome-stable/google-chrome-stable_${CHROME_VERSION}_amd64.deb
 RUN apt-get -y update
-RUN apt-get install -y ./google-chrome-stable_${CHROME_VERSION}_amd64.deb
+RUN apt-get install -y ./google-chrome-stable_${CHROME_VERSION}_amd64.deb
+
+RUN gem update --system 3.3.22
+RUN gem install bundler:2.4.22
+RUN gem install ffi:1.17.1
+
+## Got the following error when trying update bundler to 1.17.3. Needed to add https://rubygems.org to trusted domains in VSCODE by clicking on the link 
+# Unable to download data from https://rubygems.org/ - SSL_connect returned=1 errno=0 state=error sslv3 alert handshake
+# too many connection resets (https://rubygems.org/quick/Marshal.4.8/bundler-1.17.3.gemspec.rz)

.devcontainer/compose.yaml

@@ -1,4 +1,4 @@
-name: "helpy"
+name: helpy_rails5
 
 services:
   rails-app:

.devcontainer/devcontainer.json

@@ -1,7 +1,7 @@
 // For format details, see https://containers.dev/implementors/json_reference/.
 // For config options, see the README at: https://github.com/devcontainers/templates/tree/main/src/ruby
 {
-	"name": "helpy",
+	"name": "helpy_rails5",
 	"dockerComposeFile": "compose.yaml",
 	"service": "rails-app",
 	"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
@@ -32,6 +32,13 @@
 
 
 	// Use 'postCreateCommand' to run commands after the container is created.
-	"postCreateCommand": "bin/setup --skip-server"
+	"postCreateCommand": "bin/setup --skip-server",
+	"customizations": {
+		"vscode": {
+			"extensions": [
+				"eamodio.gitlens"
+			]
+		}
+	}
   }
 

.gitignore

@@ -37,4 +37,5 @@ public/uploads
 /certs
 /postgres
 
-/.fossa.yml
+/.fossa.yml
+test_results.txt

Dockerfile

@@ -1,9 +1,9 @@
-FROM ruby:2.5
+FROM ruby:2.6.10
 
 ENV RAILS_ENV=production \
     HELPY_HOME=/helpy \
     HELPY_USER=helpyuser \
-    HELPY_SLACK_INTEGRATION_ENABLED=true \
+    HELPY_SLACK_INTEGRATION_ENABLED=false \
     BUNDLE_PATH=/opt/helpy-bundle
 
 RUN apt-get update \
@@ -16,6 +16,10 @@ RUN useradd --no-create-home $HELPY_USER \
   && mkdir -p $HELPY_HOME $BUNDLE_PATH \
   && chown -R $HELPY_USER:$HELPY_USER $HELPY_HOME $BUNDLE_PATH
 
+RUN gem update --system 3.3.22 
+RUN gem install ffi -v 1.17.1
+RUN gem install bundler -v 2.4.22
+
 WORKDIR $HELPY_HOME
 
 COPY Gemfile Gemfile.lock $HELPY_HOME/
@@ -27,8 +31,8 @@ USER $HELPY_USER
 
 # add the slack integration gem to the Gemfile if the HELPY_SLACK_INTEGRATION_ENABLED is true
 # use `test` for sh compatibility, also use only one `=`. also for sh compatibility
-RUN test "$HELPY_SLACK_INTEGRATION_ENABLED" = "true" \
-    && sed -i '128i\gem "helpy_slack", git: "https://github.com/helpyio/helpy_slack.git", branch: "master"' $HELPY_HOME/Gemfile
+# RUN test "$HELPY_SLACK_INTEGRATION_ENABLED" = "true" \
+#    && sed -i '128i\gem "helpy_slack", git: "https://github.com/helpyio/helpy_slack.git", branch: "master"' $HELPY_HOME/Gemfile
 
 RUN bundle install --without test development
 

Gemfile

@@ -1,6 +1,6 @@
 source 'https://rubygems.org'
 
-gem 'rails', '4.2.11.1'
+gem 'rails', '< 5.1'
 
 # Use postgresql as the database for Active Record
 gem 'pg', '~> 0.20.0'
@@ -10,16 +10,27 @@ gem 'sass-rails', '~> 5.0.7'
 # Use Uglifier as compressor for JavaScript assets
 gem 'uglifier', '>= 1.3.0'
 
+# Need to include for rails 5
+gem 'ffi', '~> 1.17', '>= 1.17.1'
+gem 'rdoc', '< 6.3'
+# Getting the following error when running test
+# NoMethodError: undefined method `new' for BigDecimal:Class
+# https://stackoverflow.com/a/60491254/16682649
+# https://github.com/ruby/bigdecimal#which-version-should-you-select
+# NOTE: BigDecimal.new and subclassing always prints warning.
+gem 'bigdecimal', '~> 1.4'
+gem 'responders', '3.0.1'
+
 # Explicitly include Nokogiri to control version
-gem 'nokogiri', '>= 1.10.4'
+gem 'nokogiri', '~> 1.10', '>= 1.10.10'
 
 # Use jquery as the JavaScript library
 gem 'jquery-rails'
 gem 'jquery-ui-rails'
 
 # Inline js validations
-gem 'client_side_validations'
-gem 'client_side_validations-simple_form'
+gem 'client_side_validations', '>= 9.3.2', '< 15'
+gem 'client_side_validations-simple_form', '~> 6'
 
 # Turbolinks makes following links in your web application faster. Read more: https://github.com/rails/turbolinks
 gem 'turbolinks', '~> 2.5.3'
@@ -42,68 +53,73 @@ gem 'ranked-model'
 # Google Analytics Measurement Protocol
 gem 'staccato'
 
-gem "rails-settings-cached", '~> 0.5.0'
+gem "rails-settings-cached", '< 0.5'
 gem 'sucker_punch', '~> 2.0'
 
 # Charting
 gem "groupdate"
 gem "chartkick"
 
 # Auth Gems
-gem 'devise', '<= 5.0.0'
+gem 'devise', '4.7.3'
 gem 'devise-i18n'
 gem 'devise-bootstrap-views'
 gem 'devise_invitable'
-gem 'omniauth'
+gem 'omniauth', '1.9.1'
 gem "omniauth-rails_csrf_protection" # TODO: remove once https://github.com/omniauth/omniauth/pull/809 is resolved
 gem 'omniauth-github'
 gem 'omniauth-twitter'
 gem 'omniauth-google-oauth2'
 gem 'omniauth-facebook'
 
 # i18n gems
-gem 'rails-i18n', '~> 4.0.9'
+gem 'rails-i18n', '~> 5.0'
 gem 'i18n-country-translations'
-gem 'route_translator'
+#gem 'route_translator', '< 6'
+gem 'route_translator', '= 5.0.2'
 gem 'http_accept_language'
 
 # API gems
-gem 'grape'
-gem 'grape-swagger'
-gem 'grape-entity'
-gem 'grape-swagger-rails'
-gem 'grape-swagger-entity'
+gem 'grape', '~> 1.8'
+gem 'grape-swagger', '~> 1.4'
+gem 'grape-entity', '~> 0.10'
+gem 'grape-swagger-rails', '~> 0.3'
+gem 'grape-swagger-entity', '~> 0.5'
 # gem 'grape-attack' #uncomment for rate limiting
-gem 'grape-kaminari'
-gem 'kaminari-grape'
+gem 'grape-kaminari', '~> 0.4'
+gem 'kaminari-grape', '~> 1.0'
 gem 'rack-cors', :require => 'rack/cors'
 
-gem 'paper_trail'
-gem 'acts-as-taggable-on', '~>3.5'
+gem 'paper_trail', '< 11'
+gem 'acts-as-taggable-on', '~> 8.1'
 
 gem 'kaminari'
 gem 'kaminari-i18n'
 
-gem 'globalize', '= 5.0.1'
-gem 'globalize-versioning'
+gem 'globalize', '<= 5.1.0'
+gem 'globalize-versioning', '<= 0.4'
 gem 'globalize-accessors'
 
 gem 'gravtastic'
 
 # File handling
-gem 'cloudinary', '1.1.7'
-gem 'attachinary'
+gem 'cloudinary', '< 2'
+#gem 'attachinary', '< 2'
+gem 'attachinary', :git => 'https://github.com/ThomasConnolly/attachinary.git'
 
-gem 'carrierwave', '~> 1.3.1'
-gem 'fog-aws'
+gem 'carrierwave', '< 3.0.0'
+gem 'fog-aws', '< 3.6'
 gem "jquery-fileupload-rails"
 gem 'mini_magick'
 
 # Bootstrap/UI Gems
-gem 'font-awesome-sass'
+# Pin font-awesome-sass to prevent error
+# RuntimeError: Neutered Exception ActionView::Template::Error: File to import not found or unreadable: font-awesome-sprockets.
+# https://stackoverflow.com/a/33792852/31278
+gem 'font-awesome-sass', '~> 4.4.0'
 gem 'bootstrap-sass'
 gem 'bootstrap_form'
-gem 'simple_form'
+gem 'simple_form', '< 4'
 gem 'twitter-bootstrap-rails'
 gem 'twitter-bootstrap-rails-confirm'
 gem 'rdiscount'
@@ -129,7 +145,7 @@ gem 'griddler-postmark'
 gem 'griddler-sparkpost'
 
 # html Email
-gem 'inky-rb', require: 'inky'
+gem 'inky-rb', '~> 1.3', require: 'inky'
 gem 'premailer-rails'
 
 gem 'rails-timeago'
@@ -154,65 +170,68 @@ gem "recaptcha", '< 3', require: "recaptcha/rails" # TODO: Update
 gem 'best_in_place', '~> 3.1'
 
 # Add onboarding component
-gem 'helpy_onboarding', git: 'https://github.com/helpyio/helpy_onboarding', branch: 'master'
-gem 'helpy_imap', git: 'https://github.com/helpyio/helpy_imap', branch: 'master'
 
 group :development, :test do
   # Audit Gemfile for security vulnerabilities
   gem 'bundler-audit', require: false
   gem 'byebug', '11.0'
   gem 'pry'
-  gem 'pry-byebug', '3.7.0'
+  gem 'pry-byebug', '~> 3.9'
   gem 'spring', '~> 2.0.2'
   gem 'annotate'
   gem 'brakeman', require: false
   gem 'rubocop', '0.83.0'
   gem 'scss-lint'
   gem 'awesome_print'
   gem 'rb-readline'
-  gem 'capybara'
+  gem 'capybara', '< 3.30'
 
 end
 
 gem 'bulk_insert'
-gem 'roo'
+gem 'roo', '< 2.8'
 gem 'ancestry'
 
 group :development do
   gem "better_errors"
+  gem "binding_of_caller"
 
   # Check Eager Loading / N+1 query problems
   # gem 'bullet'
   gem 'scout_apm'
 
   # Access an IRB console on exception pages or by using <%= console %> in views
   gem 'web-console', '~> 3.3'
+  gem 'meta_request', '0.7.3'
 end
 
 group :test do
-  gem 'minitest'
+  gem 'minitest', '5.10.3'
   gem 'minitest-reporters'
   gem 'minitest-retry'
-  gem 'shoulda', '3.5' # Required for minitest
-  gem 'shoulda-matchers', '~> 2.0'  # Required for minitest
-  gem 'factory_bot_rails'
-  gem 'webdrivers'
-  gem 'capybara-email'
-  gem 'selenium-webdriver', '3.141.0'
+  gem 'shoulda', '~> 3.5' # Required for minitest
+  gem 'shoulda-matchers', '~> 3.0'  # Required for minitest
+  gem 'factory_bot', '< 6.3'
+  gem 'factory_bot_rails', '< 6.4'
+  gem 'webdrivers', '< 5'
+  gem 'capybara-email', '~> 3.0'
+  gem 'selenium-webdriver', '< 4.0'
   # gem 'chromedriver-helper'
   gem 'launchy'
   gem "codeclimate-test-reporter",require: nil
   gem 'simplecov', :require => false
 
   # remove this for Rails 5 because the function is already included
-  gem 'test_after_commit'
+  #gem 'test_after_commit'
+  # assigns has been extracted to a gem.
+  gem 'rails-controller-testing'
 end
 
 group :production do
   # Uncomment this gem for Heroku:
   # gem 'rails_12factor'
   gem 'unicorn' #kept for backwards compatibility
-  gem 'puma'
+  gem 'puma', '< 6'
 end
 
-ruby '>= 2.2', '< 3.0'
+ruby '>= 2.2', '< 2.7'