Skip to content

fix(cli): tx history --before now uses beforeSignature #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mooncitydev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): tx history --before now uses beforeSignature #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions helius-cli/src/commands/tx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import chalk from "chalk";
import type { GetEnhancedTransactionsByAddressRequest } from "helius-sdk/enhanced/types";
import { setupClient, type ResolveOptions } from "../lib/helius.js";
import { formatSol, formatTimestamp, formatAddress, formatEnumLabel } from "../lib/formatters.js";
import { outputJson, exitWithError, handleCommandError, createSpinner, withRetry, type OutputOptions, type RetryOptions } from "../lib/output.js";
Expand Down Expand Up @@ -63,9 +64,10 @@ export async function txHistoryCommand(address: string, options: TxOptions & { l
const addrErr = validateAddress(address);
if (addrErr) exitWithError("INVALID_ADDRESS", addrErr, undefined, !!options.json);
const helius = await setupClient(spinner, options, "Fetching transaction history...");
const params: any = { address };
const params: GetEnhancedTransactionsByAddressRequest = { address };
if (options.limit) params.limit = parseInt(options.limit, 10);
if (options.before) params.before = options.before;
// SDK ignores unknown keys; `before` was a silent no-op (see enhanced-transactions docs).
if (options.before) params.beforeSignature = options.before;
if (options.type) params.type = options.type;
const result = await withRetry(() => helius.enhanced.getTransactionsByAddress(params), options, spinner);
spinner?.stop();
Expand Down
Loading