fix(cli): tx history --before now uses beforeSignature#116
Open
mooncitydev wants to merge 1 commit into
Open
Conversation
the enhanced sdk only reads beforeSignature; passing before was ignored so pagination kept returning the first page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey team, noticed the cli path for
helius tx historywas passingbeforeintoenhanced.getTransactionsByAddressbut the sdk only readsbeforeSignature. extra keys just get ignored so pagination never moved and you would keep seeing the first page.mapped the flag to
beforeSignatureand typed the params asGetEnhancedTransactionsByAddressRequestso the shape stays honest.test plan
npm run buildinhelius-clihelius tx history <addr> --before <sig>and confirm results change vs the first page