Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency_support/com_icarus_iverilog: bump version #184

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

proppy
Copy link
Collaborator

@proppy proppy commented Sep 14, 2023

required by google/xls#726

@proppy
Copy link
Collaborator Author

proppy commented Sep 14, 2023

/gcbrun

@mithro
Copy link
Member

mithro commented Oct 25, 2023

@proppy - Is this pull request worth rebasing and landing now?

@proppy
Copy link
Collaborator Author

proppy commented Oct 26, 2023

@mithro this needs to be rebase against internal BUILD file changes (the iverilog project file structure changed quite a bit in 5 years)

@proppy
Copy link
Collaborator Author

proppy commented Oct 31, 2023

/gcbrun

@proppy
Copy link
Collaborator Author

proppy commented Oct 31, 2023

Looks like cocotb tests fail because of the way vvp and iverilog are invoked:

Step #1: //cocotb/tests:cocotb_counter                                            FAILED in 0.3s

with the following error:

Unable to find dependencies (looking under /home/proppy/.cache/bazel/_bazel_proppy/530ec4e06f73c694e11ff02f6133cd51/sandbox/linux-sandbox/2694/execroot/rules_hdl/bazel-out/k8-fastbuild/bin/cocotb/tests/cocotb_runner.sh.runfiles/rules_hdl/external/com_icarus_iverilog/iverilog.runfiles/com_icarus_iverilog).

while the files themselves are in:

$ ls bazel-out/k8-fastbuild/bin/cocotb/tests/cocotb_runner.sh.runfiles/rules_hdl/external/com_icarus_iverilog/
iverilog      system.vpi      vhdl_sys.vpi     vvp-bin
iverilog-bin  v2005_math.vpi  vhdl_textio.vpi  vvp.conf
ivl           v2009.vpi       vpi_debug.vpi    vvp.tgt
ivlpp         va_math.vpi     vvp

@proppy proppy requested review from rw1nkler and QuantamHD October 31, 2023 07:43
@proppy
Copy link
Collaborator Author

proppy commented Oct 31, 2023

/gcbrun

@proppy proppy requested a review from mithro October 31, 2023 07:43
@QuantamHD QuantamHD merged commit 2d34013 into hdl:main Oct 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants