bazelrc: enable llvm toolchain #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be fine to enable by default given that it works in CI. Unfortunately since we changed Bazel build flags it'll need to rebuild everything which is gonna take a while for us to observe the result, may time out the first go around, but running it locally too and if that looks ok we'll put it in and see how it goes. |
That shouldn't be a concern anymore with the dedicated runners. |
proppy
commented
Sep 14, 2023
|
|
||
| maybe( | ||
| http_archive, | ||
| name = "rules_hdl", | ||
| sha256 = git_sha256, | ||
| strip_prefix = "bazel_rules_hdl-%s" % git_hash, | ||
| urls = [ | ||
| "https://github.com/hdl/bazel_rules_hdl/archive/%s.tar.gz" % git_hash, | ||
| "https://github.com/proppy/bazel_rules_hdl/archive/%s.tar.gz" % git_hash, |
There was a problem hiding this comment.
trying hdl/bazel_rules_hdl#184 out, and see if it fixes the CI; will update once merged.
|
Superseeded by 72b254f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/hdl/conda-eda/blob/master/hls/xls/use-llvm-toolchain.patch
Fixes #558 #141
@cdleary is it fine to enable by default?