-
Notifications
You must be signed in to change notification settings - Fork 9.9k
[Enhancement] aws_s3vectors_index: Add metadata_configuration and encryption_configuration blocks
#45470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] aws_s3vectors_index: Add metadata_configuration and encryption_configuration blocks
#45470
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
metatdata_configuration and encryption_configuration blocksmetadata_configuration and encryption_configuration blocks
c76c24f to
2ad6a29
Compare
ewbankkit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccS3VectorsIndex_' PKG=s3vectors ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/s3vectors/... -v -count 1 -parallel 3 -run=TestAccS3VectorsIndex_ -timeout 360m -vet=off
2025/12/08 09:05:54 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/08 09:05:54 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccS3VectorsIndex_Identity_Basic
=== PAUSE TestAccS3VectorsIndex_Identity_Basic
=== RUN TestAccS3VectorsIndex_Identity_RegionOverride
=== PAUSE TestAccS3VectorsIndex_Identity_RegionOverride
=== RUN TestAccS3VectorsIndex_tags
=== PAUSE TestAccS3VectorsIndex_tags
=== RUN TestAccS3VectorsIndex_tags_null
=== PAUSE TestAccS3VectorsIndex_tags_null
=== RUN TestAccS3VectorsIndex_tags_EmptyMap
=== PAUSE TestAccS3VectorsIndex_tags_EmptyMap
=== RUN TestAccS3VectorsIndex_tags_AddOnUpdate
=== PAUSE TestAccS3VectorsIndex_tags_AddOnUpdate
=== RUN TestAccS3VectorsIndex_tags_EmptyTag_OnCreate
=== PAUSE TestAccS3VectorsIndex_tags_EmptyTag_OnCreate
=== RUN TestAccS3VectorsIndex_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccS3VectorsIndex_tags_EmptyTag_OnUpdate_Add
=== RUN TestAccS3VectorsIndex_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccS3VectorsIndex_tags_EmptyTag_OnUpdate_Replace
=== RUN TestAccS3VectorsIndex_tags_DefaultTags_providerOnly
=== PAUSE TestAccS3VectorsIndex_tags_DefaultTags_providerOnly
=== RUN TestAccS3VectorsIndex_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccS3VectorsIndex_tags_DefaultTags_nonOverlapping
=== RUN TestAccS3VectorsIndex_tags_DefaultTags_overlapping
=== PAUSE TestAccS3VectorsIndex_tags_DefaultTags_overlapping
=== RUN TestAccS3VectorsIndex_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccS3VectorsIndex_tags_DefaultTags_updateToProviderOnly
=== RUN TestAccS3VectorsIndex_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccS3VectorsIndex_tags_DefaultTags_updateToResourceOnly
=== RUN TestAccS3VectorsIndex_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccS3VectorsIndex_tags_DefaultTags_emptyResourceTag
=== RUN TestAccS3VectorsIndex_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccS3VectorsIndex_tags_DefaultTags_emptyProviderOnlyTag
=== RUN TestAccS3VectorsIndex_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccS3VectorsIndex_tags_DefaultTags_nullOverlappingResourceTag
=== RUN TestAccS3VectorsIndex_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccS3VectorsIndex_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN TestAccS3VectorsIndex_tags_ComputedTag_OnCreate
=== PAUSE TestAccS3VectorsIndex_tags_ComputedTag_OnCreate
=== RUN TestAccS3VectorsIndex_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccS3VectorsIndex_tags_ComputedTag_OnUpdate_Add
=== RUN TestAccS3VectorsIndex_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccS3VectorsIndex_tags_ComputedTag_OnUpdate_Replace
=== RUN TestAccS3VectorsIndex_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccS3VectorsIndex_tags_IgnoreTags_Overlap_DefaultTag
=== RUN TestAccS3VectorsIndex_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccS3VectorsIndex_tags_IgnoreTags_Overlap_ResourceTag
=== RUN TestAccS3VectorsIndex_basic
=== PAUSE TestAccS3VectorsIndex_basic
=== RUN TestAccS3VectorsIndex_encryptionConfigurationAES256
=== PAUSE TestAccS3VectorsIndex_encryptionConfigurationAES256
=== RUN TestAccS3VectorsIndex_encryptionConfigurationCMK
=== PAUSE TestAccS3VectorsIndex_encryptionConfigurationCMK
=== RUN TestAccS3VectorsIndex_metadataConfiguration
=== PAUSE TestAccS3VectorsIndex_metadataConfiguration
=== RUN TestAccS3VectorsIndex_disappears
=== PAUSE TestAccS3VectorsIndex_disappears
=== RUN TestAccS3VectorsIndex_withVector
=== PAUSE TestAccS3VectorsIndex_withVector
=== CONT TestAccS3VectorsIndex_Identity_Basic
=== CONT TestAccS3VectorsIndex_tags_DefaultTags_emptyProviderOnlyTag
=== CONT TestAccS3VectorsIndex_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccS3VectorsIndex_tags_DefaultTags_emptyProviderOnlyTag (16.00s)
=== CONT TestAccS3VectorsIndex_withVector
--- PASS: TestAccS3VectorsIndex_Identity_Basic (22.79s)
=== CONT TestAccS3VectorsIndex_disappears
--- PASS: TestAccS3VectorsIndex_withVector (11.94s)
=== CONT TestAccS3VectorsIndex_metadataConfiguration
--- PASS: TestAccS3VectorsIndex_tags_IgnoreTags_Overlap_ResourceTag (34.48s)
=== CONT TestAccS3VectorsIndex_encryptionConfigurationCMK
--- PASS: TestAccS3VectorsIndex_disappears (12.15s)
=== CONT TestAccS3VectorsIndex_encryptionConfigurationAES256
--- PASS: TestAccS3VectorsIndex_metadataConfiguration (15.01s)
=== CONT TestAccS3VectorsIndex_basic
--- PASS: TestAccS3VectorsIndex_encryptionConfigurationAES256 (14.92s)
=== CONT TestAccS3VectorsIndex_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccS3VectorsIndex_encryptionConfigurationCMK (20.42s)
=== CONT TestAccS3VectorsIndex_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccS3VectorsIndex_basic (14.87s)
=== CONT TestAccS3VectorsIndex_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccS3VectorsIndex_tags_DefaultTags_emptyResourceTag (15.02s)
=== CONT TestAccS3VectorsIndex_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccS3VectorsIndex_tags_EmptyTag_OnUpdate_Replace (23.99s)
=== CONT TestAccS3VectorsIndex_tags_DefaultTags_overlapping
--- PASS: TestAccS3VectorsIndex_tags_DefaultTags_updateToResourceOnly (24.66s)
=== CONT TestAccS3VectorsIndex_tags_DefaultTags_nonOverlapping
--- PASS: TestAccS3VectorsIndex_tags_DefaultTags_updateToProviderOnly (25.05s)
=== CONT TestAccS3VectorsIndex_tags_DefaultTags_providerOnly
--- PASS: TestAccS3VectorsIndex_tags_DefaultTags_overlapping (40.84s)
=== CONT TestAccS3VectorsIndex_tags_EmptyMap
--- PASS: TestAccS3VectorsIndex_tags_DefaultTags_nonOverlapping (40.18s)
=== CONT TestAccS3VectorsIndex_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccS3VectorsIndex_tags_EmptyMap (14.84s)
=== CONT TestAccS3VectorsIndex_tags_EmptyTag_OnCreate
--- PASS: TestAccS3VectorsIndex_tags_DefaultTags_providerOnly (52.53s)
=== CONT TestAccS3VectorsIndex_tags_AddOnUpdate
--- PASS: TestAccS3VectorsIndex_tags_EmptyTag_OnCreate (26.74s)
=== CONT TestAccS3VectorsIndex_tags
--- PASS: TestAccS3VectorsIndex_tags_EmptyTag_OnUpdate_Add (36.45s)
=== CONT TestAccS3VectorsIndex_tags_null
--- PASS: TestAccS3VectorsIndex_tags_AddOnUpdate (23.85s)
=== CONT TestAccS3VectorsIndex_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccS3VectorsIndex_tags_null (14.87s)
=== CONT TestAccS3VectorsIndex_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccS3VectorsIndex_tags_ComputedTag_OnUpdate_Add (31.54s)
=== CONT TestAccS3VectorsIndex_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccS3VectorsIndex_tags_IgnoreTags_Overlap_DefaultTag (33.64s)
=== CONT TestAccS3VectorsIndex_Identity_RegionOverride
--- PASS: TestAccS3VectorsIndex_tags (53.95s)
=== CONT TestAccS3VectorsIndex_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccS3VectorsIndex_tags_DefaultTags_nullNonOverlappingResourceTag (15.74s)
=== CONT TestAccS3VectorsIndex_tags_ComputedTag_OnCreate
--- PASS: TestAccS3VectorsIndex_tags_ComputedTag_OnUpdate_Replace (28.38s)
=== CONT TestAccS3VectorsIndex_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccS3VectorsIndex_Identity_RegionOverride (26.28s)
--- PASS: TestAccS3VectorsIndex_tags_ComputedTag_OnCreate (17.91s)
--- PASS: TestAccS3VectorsIndex_tags_DefaultTags_nullOverlappingResourceTag (14.98s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3vectors 251.682s|
@tabito-hara Thanks for the contribution 🎉 👏. |
|
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
|
This functionality has been released in v6.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
This PR adds
metadata_configurationandencryption_configurationblocks toaws_s3vectors_indexresource.Relations
Closes #45447
References
https://docs.aws.amazon.com/AmazonS3/latest/API/API_S3VectorBuckets_CreateIndex.html
Output from Acceptance Testing