Skip to content

Conversation

@evan-cohen
Copy link
Contributor

@evan-cohen evan-cohen commented Dec 11, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Description

Resolves an inconsistency between the documentation and implementation for the encryption_configuration block of the aws_s3vectors_index resource as introduced in v6.26.0.

The enhancement to the aws_s3vectors_index resource in #45470 includes an encryption_configuration block with a kms_key_arn attribute:

type indexEncryptionConfigurationModel struct {
KMSKeyARN fwtypes.ARN `tfsdk:"kms_key_arn"`
SseType fwtypes.StringEnum[awstypes.SseType] `tfsdk:"sse_type"`
}

resource "aws_s3vectors_index" "test" {
index_name = %[1]q
vector_bucket_name = aws_s3vectors_vector_bucket.test.vector_bucket_name
data_type = "float32"
dimension = 2
distance_metric = "euclidean"
encryption_configuration {
kms_key_arn = aws_kms_key.test.arn
sse_type = "aws:kms"
}
}

...but the corresponding documentation uses the attribute name "kms_key_id" instead:

The `encryption_configuration` block supports the following attributes:
* `kms_key_id` - (Optional, Forces new resource) AWS Key Management Service (KMS) customer managed key ID to use for the encryption configuration. This parameter is allowed if and only if `sse_type` is set to `aws:kms`.
* `sse_type` - (Optional, Forces new resource) Type of encryption to use. Valid values: `AES256`, `aws:kms`. Defaults to `AES256`.

Relations

Relates #45470

@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/s3vectors Issues and PRs that pertain to the s3vectors service. size/XS Managed by automation to categorize the size of a PR. labels Dec 11, 2025
@evan-cohen evan-cohen marked this pull request as ready for review December 11, 2025 21:10
@evan-cohen evan-cohen requested a review from a team as a code owner December 11, 2025 21:10
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 11, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@evan-cohen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 819851a into hashicorp:main Dec 11, 2025
23 checks passed
@github-actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.27.0 milestone Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. service/s3vectors Issues and PRs that pertain to the s3vectors service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants