TFECO-9166: Add support for ResourceIdentity#SchemaFunc to allow providers to save RAM #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
changed the title
austinvalle
approved these changes
Mar 27, 2025
| @@ -37,6 +37,12 @@ type ResourceIdentity struct { | |||
| // previous resource schemas. | |||
| Schema map[string]*Schema | |||
|
|
|||
| // SchemaFunc is an optional function that returns the schema for the | |||
There was a problem hiding this comment.
Do we want to just remove Schema now?
Also, since we'll likely put another alpha out, might make sense to add a changelog describing this breaking change between alphas
There was a problem hiding this comment.
Also if we remove Schema we should update the comment here to reflect that it's the only way to define an identity schema 😄
There was a problem hiding this comment.
Also if we remove Schema we should update the comment here to reflect that it's the only way to define an identity schema 😄
| @@ -70,3 +76,18 @@ type ResourceIdentity struct { | |||
| // identity schema version data for a managed resource instance. Values must | |||
| // align to the typing mentioned above. | |||
| type ResourceIdentityUpgradeFunc func(ctx context.Context, rawState map[string]interface{}, meta interface{}) (map[string]interface{}, error) | |||
|
|
|||
| // SchemaMap returns the schema information for this Resource whether it is | |||
There was a problem hiding this comment.
Suggested change
| // SchemaMap returns the schema information for this Resource whether it is | |
| // SchemaMap returns the schema information for this resource identity whether it is |
There was a problem hiding this comment.
Also same comment here if we remove the Schema field, to update the pkg comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.