TFECO-9206 Add validation to check whether the identity that we're about to send back to Terraform is complete #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
changed the title
austinvalle
reviewed
Mar 27, 2025
Comment on lines
+932
to
+939
| // validate every attribute exists and is not null | ||
| identityAttrs := newIdentityVal.AsValueMap() | ||
| for k := range identityBlock.Attributes { | ||
| if v, ok := identityAttrs[k]; !ok || v.IsNull() || !v.IsWhollyKnown() { | ||
| resp.Diagnostics = convert.AppendProtoDiag(ctx, resp.Diagnostics, fmt.Errorf("identity data missing for attribute '%s'. This is a bug in the provider, which should be reported in the provider's own issue tracker.", k)) | ||
| return resp, nil | ||
| } | ||
| } |
There was a problem hiding this comment.
Wondering if we should duplicate this validation in the provider? We know core needs/will have this logic at some point and we don't typically do validation like this in the SDKs. (For example, ReadResource it's invalid to return a NewState that has unknown values, which core validates, but the SDKs do not)
If we do decide that we want to validate this in the providers, we might consider doing it at the terraform-plugin-go level, so it applies to terraform-plugin-framework as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1459