Skip to content

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Oct 3, 2025

Context

Fixed bug where the OFFSET function was ignoring the sheet reference in the provided address.

How did you test your changes?

  • new unit tests
  • unit tests pass

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes [Bug]: Wrong result when referencing a different sheet in OFFSET function #1477

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba changed the base branch from feature/issue-911 to develop October 3, 2025 10:45
@sequba sequba force-pushed the feature/issue-1477-fix branch from a1e63bd to 886e605 Compare October 6, 2025 10:02
Copy link

github-actions bot commented Oct 6, 2025

Performance comparison of head (afbb730) vs base (3cc65df)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 504.64 | 510.97 | +1.25%
                                      Sheet B | 165.47 | 165.15 | -0.19%
                                      Sheet T | 144.54 | 143.81 | -0.51%
                                Column ranges | 512.75 | 510.45 | -0.45%
Sheet A:  change value, add/remove row/column |   15.1 |  13.89 | -8.01%
 Sheet B: change value, add/remove row/column | 131.17 | 131.36 | +0.14%
                   Column ranges - add column |  155.1 | 149.07 | -3.89%
                Column ranges - without batch | 447.39 | 445.06 | -0.52%
                        Column ranges - batch | 116.17 | 115.55 | -0.53%

@sequba sequba marked this pull request as ready for review October 6, 2025 12:41
@sequba sequba requested a review from qunabu October 6, 2025 12:42
@sequba sequba changed the title Feature/issue-1477-fix Fix bug where the OFFSET function was ignoring the sheet reference in the provided address Oct 6, 2025
@sequba sequba merged commit 31f70f9 into develop Oct 6, 2025
25 checks passed
@sequba sequba deleted the feature/issue-1477-fix branch October 6, 2025 13:52
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (3cc65df) to head (afbb730).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1548   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14524    14526    +2     
  Branches      3169     3171    +2     
========================================
+ Hits         14121    14123    +2     
  Misses         396      396           
  Partials         7        7           
Files with missing lines Coverage Δ
src/parser/FormulaParser.ts 97.61% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants