Fix bug where the OFFSET function was ignoring the sheet reference in the provided address (#1548)

* Add unit tests that reproduce the issue

* Add changelog entry

* Make OFFSET read the sheet ref in the provided address

* Adjust eslint rules

* Fix TS type warning

* Fix eslint warning

Author: sequba

.eslintrc.js

@@ -90,7 +90,9 @@ module.exports = {
     'jsdoc/empty-tags': 'warn',
     'jsdoc/implements-on-classes': 'warn',
     'jsdoc/multiline-blocks': 'warn',
-    'jsdoc/tag-lines': 'warn',
+    'jsdoc/tag-lines': ['warn', 'never', {
+      startLines: 1,
+    }],
     'jsdoc/no-multi-asterisks': 'warn',
     'jsdoc/require-param-description': 'warn',
     'jsdoc/require-param-name': 'warn',
@@ -104,8 +106,9 @@ module.exports = {
     'jsdoc/require-yields-check': 'warn',
     'jsdoc/valid-types': 'warn',
     'jsdoc/require-jsdoc': ['warn', {
+      checkConstructors: false,
       require: {
-        ArrowFunctionExpression: true,
+        ArrowFunctionExpression: false,
         ClassDeclaration: true,
         ClassExpression: true,
         FunctionDeclaration: true,

CHANGELOG.md

@@ -7,6 +7,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+### Fixed
+
+- Fixed an issue where the `OFFSET` function was ignoring the sheet reference in the provided address. [#1477](https://github.com/handsontable/hyperformula/issues/1477)
+
 ## [3.0.1] - 2025-08-11
 
 ### Fixed

package.json

@@ -78,7 +78,7 @@
     "test": "npm-run-all lint test:unit test:browser test:compatibility",
     "test:unit": "cross-env NODE_ICU_DATA=node_modules/full-icu jest",
     "test:watch": "cross-env NODE_ICU_DATA=node_modules/full-icu jest --watch",
-    "test:watch-tdd": "cross-env NODE_ICU_DATA=node_modules/full-icu jest --watch xlookup",
+    "test:tdd": "cross-env NODE_ICU_DATA=node_modules/full-icu jest --watch offset",
     "test:coverage": "npm run test:unit -- --coverage",
     "test:logMemory": "cross-env NODE_ICU_DATA=node_modules/full-icu jest --runInBand --logHeapUsage",
     "test:unit.ci": "cross-env NODE_ICU_DATA=node_modules/full-icu node --expose-gc ./node_modules/jest/bin/jest --forceExit",

src/parser/FormulaParser.ts

@@ -140,7 +140,7 @@ export class FormulaParser extends EmbeddedActionsParser {
     return this.OR([
       {ALT: () => this.SUBRULE(this.booleanExpression)},
       {ALT: EMPTY_ALT(buildEmptyArgAst())}
-    ])
+    ]) as Ast
   })
 
   /**
@@ -318,7 +318,7 @@ export class FormulaParser extends EmbeddedActionsParser {
           }
         },
       },
-    ])
+    ]) as Ast
   })
 
   /**
@@ -371,7 +371,7 @@ export class FormulaParser extends EmbeddedActionsParser {
           }
         },
       },
-    ])
+    ]) as Ast
   })
 
   /**
@@ -448,7 +448,7 @@ export class FormulaParser extends EmbeddedActionsParser {
       {
         ALT: () => this.SUBRULE(this.parenthesisExpression)
       }
-    ])
+    ]) as Ast
   })
 
   constructor(lexerConfig: LexerConfig, sheetMapping: SheetMappingFn) {
@@ -556,7 +556,7 @@ export class FormulaParser extends EmbeddedActionsParser {
           }
         },
       },
-    ]))
+    ])) as Ast
   })
 
   private rightUnaryOpAtomicExpression: AstRule = this.RULE('rightUnaryOpAtomicExpression', () => {
@@ -595,7 +595,7 @@ export class FormulaParser extends EmbeddedActionsParser {
       {
         ALT: () => this.SUBRULE2(this.rightUnaryOpAtomicExpression),
       },
-    ])
+    ]) as Ast
   })
 
   /**
@@ -817,6 +817,7 @@ export class FormulaParser extends EmbeddedActionsParser {
       cellArg.reference.col + colShift,
       cellArg.reference.row + rowShift,
       cellArg.reference.type,
+      cellArg.reference.sheet ?? undefined,
     )
 
     let absoluteCol = topLeftCorner.col

test/unit/parser/offset-translation.spec.ts

@@ -1,6 +1,10 @@
+import { HyperFormula } from '../../../src'
 import {CellError, ErrorType} from '../../../src/Cell'
 import {Config} from '../../../src/Config'
+import { SheetMapping } from '../../../src/DependencyGraph'
 import {ErrorMessage} from '../../../src/error-message'
+import { buildTranslationPackage } from '../../../src/i18n'
+import { enUS } from '../../../src/i18n/languages'
 import {AstNodeType, CellAddress, CellRangeAst, CellReferenceAst, ErrorAst} from '../../../src/parser'
 import {adr} from '../testUtils'
 import {buildEmptyParserWithCaching} from './common'
@@ -175,4 +179,24 @@ describe('Parser - OFFSET to reference translation', () => {
     expect(ast.type).toBe(AstNodeType.CELL_REFERENCE)
     expect(ast.reference).toEqual(CellAddress.relative(4, 13))
   })
+
+  it('parser returns address with a sheet reference', () => {
+    const sheetMapping = new SheetMapping(buildTranslationPackage(enUS))
+    sheetMapping.addSheet('Sheet1')
+    sheetMapping.addSheet('Sheet2')
+    const parser = buildEmptyParserWithCaching(new Config(), sheetMapping)
+
+    const ast = parser.parse('=OFFSET(Sheet1!A1, 0, 0)', adr('A1', 1)).ast as CellReferenceAst
+    expect(ast.type).toBe(AstNodeType.CELL_REFERENCE)
+    expect(ast.reference).toEqual(CellAddress.relative(0, 0, 0))
+  })
+
+  it('function OFFSET can reference a different sheet', () => {
+    const engine = HyperFormula.buildFromSheets({
+      Sheet1: [['sheet1']],
+      Sheet2: [['sheet2', '=OFFSET(Sheet1!A1, 0, 0)']],
+    })
+
+    expect(engine.getCellValue(adr('B1', engine.getSheetId('Sheet2')))).toEqual('sheet1')
+  })
 })