-
Notifications
You must be signed in to change notification settings - Fork 12
Mb-Vue 2 Setup #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marlenabaker-qz
wants to merge
5
commits into
master
Choose a base branch
from
mb-vue-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| .DS_Store | ||
| node_modules | ||
| /dist | ||
|
|
||
|
|
||
| # local env files | ||
| .env.local | ||
| .env.*.local | ||
|
|
||
| # Log files | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
|
|
||
| # Editor directories and files | ||
| .idea | ||
| .vscode | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Hotfix for Node 8.x | ||
| --install.ignore-engines true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # vue-js | ||
|
|
||
| ### How to run this app | ||
|
|
||
| 1. `npm install` or `yarn install` | ||
| 2. `npm serve` or `yarn serve` | ||
| 3. Visit http://localhost:5678 and make sure the page loads! | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| module.exports = { | ||
| presets: [ | ||
| '@vue/cli-plugin-babel/preset' | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "name": "vue-js", | ||
| "version": "0.1.0", | ||
| "private": true, | ||
| "scripts": { | ||
| "serve": "vue-cli-service serve", | ||
| "build": "vue-cli-service build", | ||
| "lint": "vue-cli-service lint" | ||
| }, | ||
| "dependencies": { | ||
| "core-js": "^3.6.5", | ||
| "vue": "^3.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@vue/cli-plugin-babel": "~4.5.0", | ||
| "@vue/cli-plugin-eslint": "~4.5.0", | ||
| "@vue/cli-service": "~4.5.0", | ||
| "@vue/compiler-sfc": "^3.0.0", | ||
| "babel-eslint": "^10.1.0", | ||
| "eslint": "^6.7.2", | ||
| "eslint-plugin-vue": "^7.0.0" | ||
| }, | ||
| "eslintConfig": { | ||
| "root": true, | ||
| "env": { | ||
| "node": true | ||
| }, | ||
| "extends": [ | ||
| "plugin:vue/vue3-essential", | ||
| "eslint:recommended" | ||
| ], | ||
| "parserOptions": { | ||
| "parser": "babel-eslint" | ||
| }, | ||
| "rules": {} | ||
| }, | ||
| "browserslist": [ | ||
| "> 1%", | ||
| "last 2 versions", | ||
| "not dead" | ||
| ] | ||
| } |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="viewport" content="width=device-width,initial-scale=1.0"> | ||
| <link rel="icon" href="<%= BASE_URL %>favicon.ico"> | ||
| <title><%= htmlWebpackPlugin.options.title %></title> | ||
| </head> | ||
| <body> | ||
| <noscript> | ||
| <strong>We're sorry but <%= htmlWebpackPlugin.options.title %> doesn't work properly without JavaScript enabled. Please enable it to continue.</strong> | ||
| </noscript> | ||
| <div id="app"></div> | ||
| <!-- built files will be auto injected --> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <template> | ||
| <LearnMode :terms="terms" /> | ||
| </template> | ||
|
|
||
| <script> | ||
| import LearnMode from './components/LearnMode.vue' | ||
|
|
||
| export default { | ||
| name: 'app', | ||
| components: { | ||
| LearnMode | ||
| }, | ||
| setup() { | ||
| return { | ||
| terms: [ | ||
| { | ||
| id: 1, | ||
| word: 'Nebraska', | ||
| definition: 'Lincoln', | ||
| }, | ||
| { | ||
| id: 2, | ||
| word: 'Massachusetts', | ||
| definition: 'Boston', | ||
| }, | ||
| { | ||
| id: 3, | ||
| word: 'California', | ||
| definition: 'Sacramento', | ||
| }, | ||
| ] | ||
| }; | ||
| } | ||
| } | ||
| </script> | ||
|
|
||
| <style> | ||
| body { | ||
| font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol"; | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
| </style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| <template> | ||
| <!-- Your HTML changes here --> | ||
| <div class="LearnMode"> | ||
| <h1 class="LearnMode-prompt">{{terms[0].word}}</h1> | ||
| <form class="LearnMode-form"> | ||
| <input auto="{true}" class="LearnMode-input" type="text" /> | ||
| <button class="LearnMode-submit" type="submit"> | ||
| Submit | ||
| </button> | ||
| </form> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script> | ||
| // Your JS changes here | ||
| export default { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we leave a comment denoting where the candidate should start coding their solution in? |
||
| name: 'LearnMode', | ||
| props: ['terms'] | ||
| } | ||
| </script> | ||
|
|
||
| <style scoped> | ||
| /* Your CSS changes here */ | ||
| .LearnMode { | ||
| padding: 20px; | ||
| } | ||
|
|
||
| .LearnMode-prompt { | ||
| margin: 0 0 16px; | ||
| } | ||
|
|
||
| .LearnMode-input { | ||
| border-radius: 2px; | ||
| border: 2px solid #d9dfe2; | ||
| display: inline-block; | ||
| font-size: 15px; | ||
| line-height: 1.35; | ||
| margin-right: 5px; | ||
| outline: 0 none; | ||
| padding: 8px; | ||
| resize: none; | ||
| } | ||
|
|
||
| .LearnMode-submit { | ||
| background: #1f6fd9; | ||
| border-radius: 2px; | ||
| border: 1px solid #1d66c8; | ||
| color: #fff; | ||
| display: inline-block; | ||
| font-size: 14px; | ||
| font-weight: 500; | ||
| height: 40px; | ||
| line-height: 2.14; | ||
| outline: 0 none; | ||
| padding: 0 20px; | ||
| text-align: center; | ||
| } | ||
|
|
||
| </style> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| import { createApp } from 'vue' | ||
| import App from './App.vue' | ||
|
|
||
| createApp(App).mount('#app') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| module.exports = { | ||
| devServer: { | ||
| port: 5678, | ||
| }, | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we mimic the setup instructions to be similar to the other skeletons (see https://github.com/guizlet/frontend-interview/blob/master/react-js/README.md as an example)? It'll be clear to the candidate the exact steps they'll need to run in order to see the question when they spin up their local server. Thanks!