Mb-Vue 2 Setup#6
Conversation
eviechan
left a comment
eviechan
left a comment
There was a problem hiding this comment.
Just tested with yarn serve and everything works for me, great job! Can we set up the server to be spun up on a different port rather than default port of 80?
| @@ -0,0 +1,19 @@ | |||
| # vue-js | |||
There was a problem hiding this comment.
Can we mimic the setup instructions to be similar to the other skeletons (see https://github.com/guizlet/frontend-interview/blob/master/react-js/README.md as an example)? It'll be clear to the candidate the exact steps they'll need to run in order to see the question when they spin up their local server. Thanks!
| yarn serve | ||
| ``` | ||
|
|
||
| ### Compiles and minifies for production |
There was a problem hiding this comment.
We probably won't need production-specific commands, since we'll be working on the problem live with candidates. I'm okay with us removing this command for now.
| </template> | ||
|
|
||
| <script> | ||
| export default { |
There was a problem hiding this comment.
Can we leave a comment denoting where the candidate should start coding their solution in?
|
|
||
| ### Compiles and hot-reloads for development | ||
| ``` | ||
| yarn serve |
There was a problem hiding this comment.
nit: best to set the commands for starting the server similar to the other skeletons, ie yarn start
There was a problem hiding this comment.
yarn serve is going to be familiar to anyone who's worked in Vue before. I understand wanting to standardize across the versions to an extent, but if we're looking to keep things comfortable and familiar, I would go with the framework default on this one.
|
@marlenabaker-qz Was wondering where we stand with this PR, we should be good to merge this PR after addressing the comments above! |
2 participants
Interview question setup in Vue 2. Made with Vue CLI 3. Copied and modified from the React boiler plate.