Comment and String locations #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swolchok
reviewed
Jun 6, 2017
lexer.cpp
Outdated
| @@ -1,15 +1,15 @@ | |||
| #line 1 "lexer.cpp" | |||
| #line 2 "/Users/barret/_/git/R/libgraphqlparser/libgraphqlparser/lexer.cpp" | |||
There was a problem hiding this comment.
this needs to be fixed up. I think cmake is running flex incorrectly; I just run it manually for commit.
|
@swolchok Cleaned up the files with the correct flex version. (Much cleaner PR) |
|
Sorry this took me so long to get to! Had a baby in April & thusly have been super busy. This looks mergeable to me. Worst case, the offsets are wrong in a different way, which doesn't leave us worse off. :) Can you clean up the commit history? Up to you whether to squash it into a single commit or a couple commits, but we shouldn't end up with "undo whitespace", "remove personal paths", etc. in our history. |
|
Congratulations! I have force updated the PR. It is much cleaner now. |
|
Thanks, that's really easy to follow. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The changes in this PR fix the issues in #51 .
*yylloctoyyextra->loc, similar to other tokensBest,
Barret