fix location positions and string / comment issues with libgraphql parser. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surgical pr changes to fix location issues for comments and strings Remove the particular call to schema2json full stack. setting default behavior to no schema parsing for speed merge for rebase Add function that supports schema definitions merge3 for rebase merge4 for rebase merge5 for rebase merge6 for rebase Add param documentation add line and column support documented
|
This PR would encompass the changes proposed in graphql/libgraphqlparser#52 to fix the issues in graphql/libgraphqlparser#51 |
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 88.92% 88.96% +0.04%
==========================================
Files 9 9
Lines 695 698 +3
==========================================
+ Hits 618 621 +3
Misses 77 77
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
surgical pr changes to fix location issues for comments and strings
Remove the particular call to schema2json full stack. Setting default behavior to no schema parsing for speed