Skip to content

[rollout-operator] use docker.io as default registry #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[rollout-operator] use docker.io as default registry #3970

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11aad59
[rollout-operator] use docker.io as default registry
KyriosGN0 Oct 31, 2025
461d951
Merge branch 'main' into registry-rollout
Sheikh-Abubaker Oct 31, 2025
9628adc
Merge branch 'main' into registry-rollout
Sheikh-Abubaker Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/rollout-operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: rollout-operator
description: "Grafana rollout-operator"
type: application
version: 0.37.0
version: 0.37.1
appVersion: v0.32.0
home: https://github.com/grafana/rollout-operator
kubeVersion: ^1.10.0-0
4 changes: 2 additions & 2 deletions charts/rollout-operator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Helm chart for deploying [Grafana rollout-operator](https://github.com/grafana/r

# rollout-operator

![Version: 0.37.0](https://img.shields.io/badge/Version-0.37.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.32.0](https://img.shields.io/badge/AppVersion-v0.32.0-informational?style=flat-square)
![Version: 0.37.1](https://img.shields.io/badge/Version-0.37.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.32.0](https://img.shields.io/badge/AppVersion-v0.32.0-informational?style=flat-square)

Grafana rollout-operator

Expand Down Expand Up @@ -55,7 +55,7 @@ Manually applying these CRDs is only required if upgrading from a chart <= v0.32
| global.commonLabels | object | `{}` | Common labels for all object directly managed by this chart. |
| hostAliases | list | `[]` | hostAliases to add |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.registry | string | `""` | |
| image.registry | string | `"docker.io"` | |
| image.repository | string | `"grafana/rollout-operator"` | |
| image.tag | string | `""` | Overrides the image tag whose default is the chart appVersion. |
| imagePullSecrets | list | `[]` | |
Expand Down
2 changes: 1 addition & 1 deletion charts/rollout-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ revisionHistoryLimit: 10

image:
repository: grafana/rollout-operator
registry: ""
registry: docker.io
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyriosGN0 Thanks for your contribution! looks good! before merging, just wanted to know if you've tested it in an identical setup mentioned in #3923 ?

Copy link
Contributor Author

@KyriosGN0 KyriosGN0 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, unfourtnetly I don't have a setup of k8s + crio

Copy link
Contributor Author

@KyriosGN0 KyriosGN0 Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sheikh-Abubaker this change will only affect users who ignore the registry option and then pass the registry in the repository field, i will add a warning in the docs about this , how does that sounds?

pullPolicy: IfNotPresent
# -- Overrides the image tag whose default is the chart appVersion.
tag: ""
Expand Down
Loading