[rollout-operator] use docker.io as default registry #3970
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AvivGuiser <[email protected]>
| image: | ||
| repository: grafana/rollout-operator | ||
| registry: "" | ||
| registry: docker.io |
Collaborator
There was a problem hiding this comment.
@KyriosGN0 Thanks for your contribution! looks good! before merging, just wanted to know if you've tested it in an identical setup mentioned in #3923 ?
Contributor
Author
There was a problem hiding this comment.
no, unfourtnetly I don't have a setup of k8s + crio
Contributor
Author
There was a problem hiding this comment.
@Sheikh-Abubaker this change will only affect users who ignore the registry option and then pass the registry in the repository field, i will add a warning in the docs about this , how does that sounds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AvivGuiser [email protected]
relates to #3923