Skip to content

Conversation

@gounthar
Copy link
Owner

@gounthar gounthar commented Jul 9, 2025

This PR contains automatically updated PR statistics data. Generated by GitHub Actions.

Summary by CodeRabbit

  • Chores
    • Updated timestamps and URLs for continuous integration and security scan status checks in consolidated PR data.
    • Refreshed timestamps and URLs for status checks in open PR data.
    • Added new JUnit 5 migration PR candidates and reorganized the candidate list, including updates to dependency bump PR references.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 9, 2025

Walkthrough

Timestamps and URL fields for status checks in consolidated pull request JSON data files were updated from April 15, 2025, to July 8, 2025. The JUnit 5 migration candidate list was also updated with new entries, reordered lines, and refreshed dependency bump PR references. No structural or logic changes occurred.

Changes

File(s) Change Summary
data/consolidated/all_prs.json,
data/consolidated/open_prs.json
Updated startedAt and completedAt timestamps and related URL fields for status checks; no structure or logic changes.
junit5_candidate_prs.txt Advanced timestamp, added new migration PRs, reordered entries, and updated dependency bump PR references.

Possibly related PRs

Poem

In the warren where data hops anew,
Timestamps leap from April’s dew.
URLs refreshed, the checks align,
JUnit lists in tidy line.
With every update, carrots cheer—
Code hops forward, crystal clear!
🥕✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @gounthar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is an automated daily update to the junit5_candidate_prs.txt file. Its primary purpose is to maintain an up-to-date record of pull requests related to JUnit 5 migration within the Jenkins ecosystem, ensuring the list reflects the current status of these ongoing efforts.

Highlights

  • Automated Data Update: This pull request automatically updates the junit5_candidate_prs.txt file, which serves as a daily collection of JUnit 5 migration pull request statistics.
  • New PRs Tracked: The update includes the addition of new pull requests, encompassing both recently opened and newly merged/closed entries related to JUnit 5 migration efforts across various Jenkins projects.
  • Data Synchronization: The file's internal timestamp has been updated to reflect the latest data collection time, and existing entries have been reordered, indicating a refresh of the tracked data.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (4)
data/consolidated/all_prs.json (1)

6624-6661: Consider splitting gigantic JSON dumps into per-day shards
At ~6 k lines (and growing daily), a single monolithic all_prs.json balloons every diff, slows reviews, and risks merge conflicts.
Storing daily/weekly shards (e.g., all_prs/2025-07-08.json) or converting the workflow to append-only newline-delimited JSON would:

  • keep diffs minimal,
  • allow partial downloads,
  • reduce conflict frequency.
data/consolidated/open_prs.json (1)

4717-4724: Empty workflowName fields – intentional?

Two new CheckRun items (name: "Jenkins" and the second “Jenkins Security Scan”) have an empty workflowName.
If that reflects reality, fine; otherwise fill the field to keep the schema consistent with other check-run records and avoid downstream null-handling edge cases.

Also applies to: 4727-4734

junit5_candidate_prs.txt (2)

4-8: Maintain list ordering for easier diff-noise tracking.

The two newly added PRs break the existing (roughly) alphabetical ordering.
Keeping a deterministic order (e.g. plugin id, then PR number) makes the file diff-friendly and helps avoid future merge conflicts.


874-875: Duplicate open entries for the same plugin risk double-processing downstream.

tekton-client-plugin now has two open entries (#424 and #421).
Unless the collector intentionally keeps multiple concurrent PRs for the same repository, consider de-duplicating to prevent:

  • inflated counts in dashboards
  • redundant notifications

If needed, prefer the newest PR or the one with the latest activity.

-# jenkinsci/tekton-client-plugin - build(deps): bump com.squareup.okhttp3:okhttp from 3.14.9 to 5.1.0 (OPEN)
-https://github.com/jenkinsci/tekton-client-plugin/pull/424

Also applies to: 886-887

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbcb69f and 8b56b88.

📒 Files selected for processing (3)
  • data/consolidated/all_prs.json (1 hunks)
  • data/consolidated/open_prs.json (1 hunks)
  • junit5_candidate_prs.txt (18 hunks)
🧰 Additional context used
🧠 Learnings (1)
junit5_candidate_prs.txt (2)
Learnt from: gounthar
PR: gounthar/alpha-omega-stats#0
File: :0-0
Timestamp: 2025-03-07T16:15:13.008Z
Learning: The jenkins-pr-collector should log all PRs found, not just the ones with specific strings like "odernizer" in the body.
Learnt from: gounthar
PR: gounthar/alpha-omega-stats#0
File: :0-0
Timestamp: 2025-03-07T16:15:13.008Z
Learning: For the jenkins-pr-collector tool, all PRs should be logged, not just those with specific keywords like "odernizer" or "recipe" in the body text.
🪛 LanguageTool
junit5_candidate_prs.txt

[grammar] ~2-~2: There might be a mistake here.
Context: ...levant URLs to junit5_pr_urls.txt after verification # jenkinsci/mail-watcher-plugin - Migrate...

(QB_NEW_EN_OTHER)


[grammar] ~4-~4: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/mail-watcher-plugin#162 # jenkinsci/groovy-plugin - Migrate tests...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~7-~7: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/groovy-plugin#92 # jenkinsci/syslog-java-client - Migrate ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~55-~55: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/amazon-ecs-plugin#387 # jenkinsci/wiz-scanner-plugin - Migrate ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~73-~73: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/display-url-api-plugin#255 # jenkinsci/command-launcher-plugin - Mig...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~76-~76: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/command-launcher-plugin#108 # jenkinsci/variant-plugin - Migrate test...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~79-~79: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/variant-plugin#116 # jenkinsci/matrix-project-plugin - Migra...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~82-~82: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/matrix-project-plugin#264 # jenkinsci/database-sqlite-plugin - Migr...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~85-~85: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/database-sqlite-plugin#163 # jenkinsci/envinject-plugin - Migrate te...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~88-~88: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/envinject-plugin#317 # jenkinsci/branch-api-plugin - Migrate t...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~91-~91: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/branch-api-plugin#509 # jenkinsci/reverse-proxy-auth-plugin - M...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~94-~94: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/reverse-proxy-auth-plugin#184 # jenkinsci/lucene-search-plugin - Migrat...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~97-~97: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/lucene-search-plugin#77 # jenkinsci/external-monitor-job-plugin -...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~100-~100: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/external-monitor-job-plugin#99 # jenkinsci/ws-cleanup-plugin - Migrate t...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~103-~103: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/ws-cleanup-plugin#230 # jenkinsci/pubsub-light-plugin - Migrate...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~106-~106: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/pubsub-light-plugin#136 # jenkinsci/gating-core-plugin - Migrate ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~148-~148: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/resource-disposer-plugin#121 # jenkinsci/support-core-plugin - Migrate...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~151-~151: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/support-core-plugin#632 # jenkinsci/dockerhub-notification-plugin...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~154-~154: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/dockerhub-notification-plugin#74 # jenkinsci/throttle-concurrent-builds-pl...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~157-~157: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/throttle-concurrent-builds-plugin#302 # jenkinsci/timestamper-plugin - Migrate ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~160-~160: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/timestamper-plugin#339 # jenkinsci/gitlab-branch-source-plugin -...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~175-~175: Use correct spacing
Context: ...plugin - Migrate tests to JUnit5 (OPEN) jenkinsci/okhttp-api-plugin#236 # jenkinsci/onepassword-secrets-plugin - ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~220-~220: Use correct spacing
Context: ...te SSHLauncherTest to JUnit5 (MERGED) jenkinsci/ssh-agents-plugin#605 # jenkinsci/dashboard-view-plugin - Migra...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~373-~373: Use correct spacing
Context: ...ugin - Migrate tests to JUnit5 (MERGED) jenkinsci/sshd-plugin#221 # jenkinsci/jenkins - Migrate tests to JU...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~400-~400: Use correct spacing
Context: ...ugin - Migrate tests to JUnit5 (MERGED) jenkinsci/mathworks-polyspace-plugin#9 # jenkinsci/authentication-tokens-plugin ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~460-~460: Use correct spacing
Context: ...ugin - Migrate tests to JUnit5 (MERGED) jenkinsci/build-history-metrics-plugin#64 # jenkinsci/influxdb-plugin - Migrate tes...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~496-~496: Use correct spacing
Context: ...ugin - Migrate tests to JUnit5 (MERGED) jenkinsci/last-changes-plugin#123 # jenkinsci/generic-webhook-trigger-plugi...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~595-~595: Use correct spacing
Context: ...ugin - Migrate tests to JUnit5 (MERGED) jenkinsci/lockable-resources-plugin#761 # jenkinsci/docker-java-api-plugin - Migr...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~649-~649: Use correct spacing
Context: ...ugin - Migrate tests to JUnit5 (MERGED) jenkinsci/token-macro-plugin#254 # jenkinsci/email-ext-plugin - Migrate te...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~682-~682: Use correct spacing
Context: ...ugin - Migrate tests to JUnit5 (MERGED) jenkinsci/global-build-stats-plugin#94 # jenkinsci/office-365-connector-plugin -...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~874-~874: Use correct spacing
Context: ...ttp3:okhttp from 3.14.9 to 5.1.0 (OPEN) jenkinsci/tekton-client-plugin#424 # jenkinsci/filesystem_scm-plugin - refac...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~877-~877: Use correct spacing
Context: ...tests): Migrate tests to JUnit 5 (OPEN) jenkinsci/filesystem_scm-plugin#30 # jenkinsci/rich-text-publisher-plugin - ...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~880-~880: Use correct spacing
Context: ...tests): Migrate tests to JUnit 5 (OPEN) jenkinsci/rich-text-publisher-plugin#13 # jenkinsci/stackrox-container-image-scan...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~883-~883: Use correct spacing
Context: ...tests): Migrate tests to JUnit 5 (OPEN) jenkinsci/stackrox-container-image-scanner-plugin#4 # jenkinsci/ansible-tower-plugin - refact...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~886-~886: Use correct spacing
Context: ...tests): Migrate tests to JUnit 5 (OPEN) jenkinsci/ansible-tower-plugin#30 # jenkinsci/yet-another-build-visualizer-...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~898-~898: Use correct spacing
Context: ...p3:okhttp from 3.14.9 to 5.0.0 (CLOSED) jenkinsci/tekton-client-plugin#422 # jenkinsci/dark-theme-plugin - Update de...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~913-~913: Use correct spacing
Context: ....v5132851f6ca_f in /bom-weekly (MERGED) jenkinsci/bom#5305 # jenkinsci/bom - chore(deps): bump org.j...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~1000-~1000: Use correct spacing
Context: ...3c9ef8 to 270.vdb_c342a_178b_f (MERGED) jenkinsci/opentelemetry-plugin#1108 # jenkinsci/bom - chore(deps): bump io.je...

(QB_NEW_EN_OTHER_ERROR_IDS_5)


[grammar] ~1183-~1183: Use correct spacing
Context: ...ito-core from 5.14.2 to 5.15.2 (MERGED) jenkinsci/tuleap-git-branch-source-plugin#600 # jenkinsci/jobcacher-plugin - chore(deps...

(QB_NEW_EN_OTHER_ERROR_IDS_5)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: updatecli
  • GitHub Check: updatecli
🔇 Additional comments (1)
junit5_candidate_prs.txt (1)

1-1: Timestamp bump looks fine.

Only the generated timestamp was updated – no concerns.

Comment on lines +6627 to 6633
"completedAt": "2025-07-08T12:15:36Z",
"conclusion": "SUCCESS",
"detailsUrl": "https://github.com/jenkinsci/git-push-plugin/actions/runs/14472963928/job/40591425929",
"detailsUrl": "https://github.com/jenkinsci/git-push-plugin/actions/runs/16142863164/job/45554195023",
"name": "security-scan / scan",
"startedAt": "2025-04-15T15:11:05Z",
"startedAt": "2025-07-08T12:12:14Z",
"status": "COMPLETED",
"workflowName": "Jenkins Security Scan"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify startedAtcompletedAt for every status check
While the sample objects here look fine (e.g., 12:12:14 → 12:15:36), it’s easy for automated refresh jobs to accidentally swap or mis-format timestamps elsewhere in this 6 k-line file. A silent ordering error would break any downstream SLA / duration metrics.

Also applies to: 6644-6650, 6654-6660


🏁 Script executed:

#!/bin/bash
# Fail if any CheckRun or StatusContext has completedAt earlier than startedAt
jq -r '..|objects|select(has("startedAt") and has("completedAt"))| [.startedAt,.completedAt] | @tsv' \
  data/consolidated/all_prs.json |
awk 'BEGIN{err=0}
     { if ($1 > $2) {print "⛔  " $0; err=1} }
     END{ exit err }'

Length of output: 14396


Detected timestamp ordering errors in all_prs.json – fixes required
The automated check found numerous entries where completedAt is earlier than startedAt, which will break SLA/duration metrics downstream. Please correct these timestamp fields at the data source or normalize the JSON so that every status check satisfies startedAtcompletedAt.

Affected locations (examples):

  • data/consolidated/all_prs.json (around lines 6627–6633, 6644–6650, 6654–6660, and many more)
    Sample mismatches:
    • 2025-03-27T21:58:21Z → 2025-03-27T21:58:20Z
    • 2025-03-27T21:58:19Z → 2025-03-27T21:58:18Z
    • 2025-03-11T11:36:02Z → 2025-03-11T11:36:01Z
    …and dozens more.

Recommended action:

  1. Update the process that generates or merges these timestamps so that completedAt is never before startedAt.
  2. Re-run the verification script to confirm all entries now satisfy the correct ordering.
🤖 Prompt for AI Agents
In data/consolidated/all_prs.json around lines 6627 to 6633, there are entries
where the completedAt timestamp is earlier than the startedAt timestamp, causing
ordering errors. To fix this, update the data generation or merging process to
ensure that for every entry, completedAt is always equal to or later than
startedAt. After making these corrections, re-run the verification script to
confirm all timestamp orderings are valid.

Comment on lines +4700 to 4706
"completedAt": "2025-07-08T12:15:36Z",
"conclusion": "SUCCESS",
"detailsUrl": "https://github.com/jenkinsci/git-push-plugin/actions/runs/14472963928/job/40591425929",
"detailsUrl": "https://github.com/jenkinsci/git-push-plugin/actions/runs/16142863164/job/45554195023",
"name": "security-scan / scan",
"startedAt": "2025-04-15T15:11:05Z",
"startedAt": "2025-07-08T12:12:14Z",
"status": "COMPLETED",
"workflowName": "Jenkins Security Scan"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Sanity-check startedAtcompletedAt across the roll-up

For the lines shown the ordering looks correct (e.g. 12:12:14Z12:15:36Z), but we’ve had a few historical regressions where large data refreshes introduced inverted timestamps on other entries.
Recommend running a quick jq/awk scan before merging:

Expect: no output.
If anything is printed, the JSON slice should be fixed before landing.

Also applies to: 4711-4713, 4717-4724, 4727-4734


🏁 Script executed:

#!/bin/bash
# Fail if any CheckRun has startedAt > completedAt
jq -r '..|objects|select(.startedAt? and .completedAt?)|
        select(.startedAt > .completedAt)|
        "\(.name)  \(.startedAt) > \(.completedAt)"' \
   data/consolidated/open_prs.json

Length of output: 15614


Fix inverted startedAt/completedAt timestamps in open_prs.json

A full jq scan uncovered multiple entries where startedAt is later than completedAt, for example:

  • SpotBugs: 2025-03-11T11:36:02Z > 2025-03-11T11:36:01Z
  • CPD: 2025-03-11T11:36:06Z > 2025-03-11T11:36:05Z
  • CheckStyle: 2025-03-11T11:36:04Z > 2025-03-11T11:36:02Z
  • Code Coverage: 2025-03-11T11:35:46Z > 2025-03-11T11:35:45Z
  • …and many more across the file

These inversions appear in the following sections:

  • Lines 4700–4706
  • Lines 4711–4713
  • Lines 4717–4724
  • Lines 4727–4734

Please correct all affected timestamp pairs before merging. You can rerun this check to verify you’ve fixed them:

jq -r '..|objects|select(.startedAt? and .completedAt?)|
        select(.startedAt > .completedAt)|
        "\(.name)  \(.startedAt) > \(.completedAt)"' \
   data/consolidated/open_prs.json

Expect no output once all entries are corrected.

🤖 Prompt for AI Agents
In data/consolidated/open_prs.json around lines 4700 to 4706, the startedAt and
completedAt timestamps are inverted, with startedAt being later than
completedAt. Review these entries and swap the values of startedAt and
completedAt wherever startedAt is greater than completedAt to ensure
chronological order. Repeat this correction for all affected sections mentioned,
then rerun the provided jq command to verify no inverted timestamps remain.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This automated PR updates the list of JUnit 5 migration candidates. The generation process re-sorts the entire file on each run, creating a large and noisy diff that obscures the actual changes. To improve reviewability, modify the generation script to maintain a stable order, grouping PRs by status (OPEN, MERGED, CLOSED) and then sorting alphabetically within each group.

Comment on lines +1 to 12
# JUnit 5 migration PR candidates found on 2025-07-09 01:43:17
# Add relevant URLs to junit5_pr_urls.txt after verification

# jenkinsci/mail-watcher-plugin - Migrate tests to JUnit5 (OPEN)
https://github.com/jenkinsci/mail-watcher-plugin/pull/162

# jenkinsci/groovy-plugin - Migrate tests to JUnit5 (OPEN)
https://github.com/jenkinsci/groovy-plugin/pull/92

# jenkinsci/syslog-java-client - Migrate tests to JUnit5 (OPEN)
https://github.com/jenkinsci/syslog-java-client/pull/181

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The automated script re-sorts the entire list of PRs on each run, creating large, noisy diffs. This makes it difficult to see what has actually changed. Modify the script to maintain a stable order by grouping PRs by status (OPEN, MERGED, CLOSED) and then sorting alphabetically within each group. This will highlight only the new additions or status changes.

Comment on lines +4 to +5
# jenkinsci/mail-watcher-plugin - Migrate tests to JUnit5 (OPEN)
https://github.com/jenkinsci/mail-watcher-plugin/pull/162
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider updating the automated script to output the new entries at the end of the file. This will make it easier to review the changes.

Comment on lines 49 to 50
# jenkinsci/jenkins-test-harness - Add JUnit5 equivalents of JUnit4 Rule implementations (OPEN)
https://github.com/jenkinsci/jenkins-test-harness/pull/988
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider updating the automated script to output the moved entries at the end of the file. This will make it easier to review the changes.

Comment on lines 67 to 68
# jenkinsci/hashicorp-vault-plugin - Migrate tests to JUnit5 (OPEN)
https://github.com/jenkinsci/hashicorp-vault-plugin/pull/346
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider updating the automated script to output the moved entries at the end of the file. This will make it easier to review the changes.

Comment on lines 145 to 146
# jenkinsci/build-failure-analyzer-plugin - Migrate tests to JUnit5 (OPEN)
https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/205
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider updating the automated script to output the moved entries at the end of the file. This will make it easier to review the changes.

Comment on lines +160 to +161
# jenkinsci/timestamper-plugin - Migrate tests to JUnit5 (OPEN)
https://github.com/jenkinsci/timestamper-plugin/pull/339
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider updating the automated script to output the moved entries at the end of the file. This will make it easier to review the changes.

@gounthar gounthar merged commit ab7ada5 into main Jul 9, 2025
7 checks passed
@gounthar gounthar deleted the auto-update-pr-data branch July 9, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants