Update PR data Daily collection (2025-07-12 01:44 UTC) #120
Conversation
WalkthroughThis update modifies several JSON and text data files to reflect recent changes in pull request metadata. It updates timestamps and Jenkins build URLs for status checks, removes a merged pull request from open lists, and reorders or corrects entries related to JUnit5 migration candidates. No code or API signatures are changed. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @gounthar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated daily update of PR statistics data. It refreshes the information for failing pull requests and reorders the list of JUnit 5 migration candidates to reflect their latest status and details.
Highlights
- Automated Data Refresh: The pull request updates daily statistics for various pull requests, ensuring the data reflects the most current state.
- Failing PR Data Update: Details for a specific failing pull request (
qy-wechat-notification-plugin/PR-13) have been updated, including itsstartedAt,completedAttimestamps, andtargetUrlto reflect a more recent CI run. - JUnit 5 Migration PRs Reordered and Updated: The list of JUnit 5 migration candidate pull requests has been refreshed and reordered. This includes updates to their
state(e.g., from OPEN to MERGED/CLOSED) and other metadata across numerous Jenkins plugins, such asssh-credentials-plugin,bitbucket-push-and-pull-request-plugin,jenkins-test-harness,credentials-plugin, and others.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR appears to be an automated data update. I've noticed some inconsistencies in the sorting of pull requests in data/junit5/junit5_candidates.json and junit5_candidate_prs.txt. While the overall goal seems to be sorting by creation date in descending order, some of the changes in this PR introduce an ascending order for certain items. This might indicate a bug in the data generation script. I've left specific comments with suggestions to correct the sorting for the affected items.
| { | ||
| "title": "Migrate tests to JUnit5", | ||
| "url": "https://github.com/jenkinsci/kobiton-integration-plugin/pull/43", | ||
| "repository": "jenkinsci/kobiton-integration-plugin", | ||
| "url": "https://github.com/jenkinsci/propelo-job-reporter-plugin/pull/28", | ||
| "repository": "jenkinsci/propelo-job-reporter-plugin", | ||
| "state": "OPEN", | ||
| "author": "strangelookingnerd", | ||
| "labels": null, | ||
| "body": "This PR aims to migrate all tests to JUnit5. Changes include:\n\nMigrate annotations and imports\nMigrate assertions\nRemove public visibility for test classes and methods\nMinor clean up\n\nI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.\nIf there are any questions, please do not hesitate to ping me.\nSubmitter checklist\n\n Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!\n Ensure that the pull request title represents the desired changelog entry\n Please describe what you did\n Link to relevant issues in GitHub or Jira\n Link to relevant pull requests, esp. upstream and downstream changes\n Ensure you have provided tests that demonstrate the feature works or the issue is fixed", | ||
| "createdAt": "2025-06-02T14:45:19Z" | ||
| "body": "This PR aims to migrate all tests to JUnit5. Changes include:\n\nMigrate annotations and imports\nMigrate assertions\nRemove public visibility for test classes and methods\nMinor clean up\n\nI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.\nIf there are any questions, please do not hesitate to ping me.\n\n Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!\n Ensure that the pull request title represents the desired changelog entry\n Please describe what you did\n Link to relevant issues in GitHub\n Link to relevant pull requests, esp. upstream and downstream changes\n Ensure you have provided tests - that demonstrates feature works or fixes the issue", | ||
| "createdAt": "2025-05-06T09:41:06Z" | ||
| }, | ||
| { | ||
| "title": "Migrate tests to JUnit5", | ||
| "url": "https://github.com/jenkinsci/propelo-job-reporter-plugin/pull/28", | ||
| "repository": "jenkinsci/propelo-job-reporter-plugin", | ||
| "url": "https://github.com/jenkinsci/kobiton-integration-plugin/pull/43", | ||
| "repository": "jenkinsci/kobiton-integration-plugin", | ||
| "state": "OPEN", | ||
| "author": "strangelookingnerd", | ||
| "labels": null, | ||
| "body": "This PR aims to migrate all tests to JUnit5. Changes include:\n\nMigrate annotations and imports\nMigrate assertions\nRemove public visibility for test classes and methods\nMinor clean up\n\nI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.\nIf there are any questions, please do not hesitate to ping me.\n\n Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!\n Ensure that the pull request title represents the desired changelog entry\n Please describe what you did\n Link to relevant issues in GitHub\n Link to relevant pull requests, esp. upstream and downstream changes\n Ensure you have provided tests - that demonstrates feature works or fixes the issue", | ||
| "createdAt": "2025-05-06T09:41:06Z" | ||
| "body": "This PR aims to migrate all tests to JUnit5. Changes include:\n\nMigrate annotations and imports\nMigrate assertions\nRemove public visibility for test classes and methods\nMinor clean up\n\nI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.\nIf there are any questions, please do not hesitate to ping me.\nSubmitter checklist\n\n Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!\n Ensure that the pull request title represents the desired changelog entry\n Please describe what you did\n Link to relevant issues in GitHub or Jira\n Link to relevant pull requests, esp. upstream and downstream changes\n Ensure you have provided tests that demonstrate the feature works or the issue is fixed", | ||
| "createdAt": "2025-06-02T14:45:19Z" | ||
| }, |
There was a problem hiding this comment.
It appears there's an inconsistency in the sorting logic for the pull requests in this file. While some parts of the file seem to be sorted in descending order by createdAt (which is great for seeing the most recent PRs first), this change introduces an ascending sort for this pair of items.
propelo-job-reporter-plugin(2025-05-06T09:41:06Z)kobiton-integration-plugin(2025-06-02T14:45:19Z)
To maintain a consistent descending order, the kobiton-integration-plugin PR should appear before the propelo-job-reporter-plugin PR. This might indicate a bug in the data collection script that should be addressed.
I suggest reverting this specific swap to maintain the descending sort order.
{
"title": "Migrate tests to JUnit5",
"url": "https://github.com/jenkinsci/kobiton-integration-plugin/pull/43",
"repository": "jenkinsci/kobiton-integration-plugin",
"state": "OPEN",
"author": "strangelookingnerd",
"labels": null,
"body": "This PR aims to migrate all tests to JUnit5. Changes include:\n\nMigrate annotations and imports\nMigrate assertions\nRemove public visibility for test classes and methods\nMinor clean up\n\nI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.\nIf there are any questions, please do not hesitate to ping me.\nSubmitter checklist\n\n Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!\n Ensure that the pull request title represents the desired changelog entry\n Please describe what you did\n Link to relevant issues in GitHub or Jira\n Link to relevant pull requests, esp. upstream and downstream changes\n Ensure you have provided tests that demonstrate the feature works or the issue is fixed",
"createdAt": "2025-06-02T14:45:19Z"
},
{
"title": "Migrate tests to JUnit5",
"url": "https://github.com/jenkinsci/propelo-job-reporter-plugin/pull/28",
"repository": "jenkinsci/propelo-job-reporter-plugin",
"state": "OPEN",
"author": "strangelookingnerd",
"labels": null,
"body": "This PR aims to migrate all tests to JUnit5. Changes include:\n\nMigrate annotations and imports\nMigrate assertions\nRemove public visibility for test classes and methods\nMinor clean up\n\nI am well aware that this is a quite large changeset however I hope that there is still interest in this PR and it will be reviewed.\nIf there are any questions, please do not hesitate to ping me.\n\n Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!\n Ensure that the pull request title represents the desired changelog entry\n Please describe what you did\n Link to relevant issues in GitHub\n Link to relevant pull requests, esp. upstream and downstream changes\n Ensure you have provided tests - that demonstrates feature works or fixes the issue",
"createdAt": "2025-05-06T09:41:06Z"
},
| # jenkinsci/propelo-job-reporter-plugin - Migrate tests to JUnit5 (OPEN) | ||
| https://github.com/jenkinsci/propelo-job-reporter-plugin/pull/28 | ||
|
|
||
| # jenkinsci/kobiton-integration-plugin - Migrate tests to JUnit5 (OPEN) | ||
| https://github.com/jenkinsci/kobiton-integration-plugin/pull/43 | ||
|
|
There was a problem hiding this comment.
Similar to the junit5_candidates.json file, there seems to be an inconsistency in the sorting of PRs here. This change results in an ascending sort by date for this pair of items, while other parts of the file are sorted descendingly.
propelo-job-reporter-plugin:2025-05-06kobiton-integration-plugin:2025-06-02
To maintain consistency, the kobiton-integration-plugin PR should come first. This suggests a potential bug in the data generation script.
# jenkinsci/kobiton-integration-plugin - Migrate tests to JUnit5 (OPEN)
https://github.com/jenkinsci/kobiton-integration-plugin/pull/43
# jenkinsci/propelo-job-reporter-plugin - Migrate tests to JUnit5 (OPEN)
https://github.com/jenkinsci/propelo-job-reporter-plugin/pull/28
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
data/junit5/junit5_candidates.json (2)
35-40: Prefer[]overnullfor an emptylabelsfieldElsewhere in the file an empty list is represented as
[], here it isnull. Normalising on one representation simplifies downstream tooling (e.g. JSON-Schema validation, JQ queries) and avoids an extra “is null?” branch.- "labels": null, + "labels": [],
3237-3260: Large embedded changelogs balloon JSON sizeThe Dependabot bodies add ~200 lines each. Storing the full release notes bloats the dataset and makes diffs noisy.
Consider trimmingbodyto the first paragraph and linking to the upstream release notes instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
data/consolidated/all_prs.json(2 hunks)data/consolidated/failing_prs.json(1 hunks)data/consolidated/open_prs.json(1 hunks)data/junit5/junit5_candidates.json(17 hunks)junit5_candidate_prs.txt(15 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: gounthar
PR: gounthar/alpha-omega-stats#0
File: :0-0
Timestamp: 2025-03-07T16:15:13.008Z
Learning: For the jenkins-pr-collector tool, all PRs should be logged, not just those with specific keywords like "odernizer" or "recipe" in the body text.
data/consolidated/open_prs.json (2)
undefined
<retrieved_learning>
Learnt from: gounthar
PR: gounthar/alpha-omega-stats#0
File: :0-0
Timestamp: 2025-03-07T16:15:13.008Z
Learning: For the jenkins-pr-collector tool, all PRs should be logged, not just those with specific keywords like "odernizer" or "recipe" in the body text.
</retrieved_learning>
<retrieved_learning>
Learnt from: gounthar
PR: gounthar/alpha-omega-stats#0
File: :0-0
Timestamp: 2025-03-07T16:15:13.008Z
Learning: The jenkins-pr-collector should log all PRs found, not just the ones with specific strings like "odernizer" in the body.
</retrieved_learning>
junit5_candidate_prs.txt (1)
Learnt from: gounthar
PR: gounthar/alpha-omega-stats#0
File: :0-0
Timestamp: 2025-03-07T16:15:13.008Z
Learning: The jenkins-pr-collector should log all PRs found, not just the ones with specific strings like "odernizer" in the body.
data/junit5/junit5_candidates.json (2)
undefined
<retrieved_learning>
Learnt from: gounthar
PR: gounthar/alpha-omega-stats#0
File: :0-0
Timestamp: 2025-03-07T16:15:13.008Z
Learning: The jenkins-pr-collector should log all PRs found, not just the ones with specific strings like "odernizer" in the body.
</retrieved_learning>
<retrieved_learning>
Learnt from: gounthar
PR: gounthar/alpha-omega-stats#0
File: :0-0
Timestamp: 2025-03-07T16:15:13.008Z
Learning: For the jenkins-pr-collector tool, all PRs should be logged, not just those with specific keywords like "odernizer" or "recipe" in the body text.
</retrieved_learning>
🔇 Additional comments (6)
data/junit5/junit5_candidates.json (1)
163-172: No duplicate of PR #988 found
A count ofhttps://github.com/jenkinsci/jenkins-test-harness/pull/988indata/junit5/junit5_candidates.jsonreturns 1 occurrence, so there’s no risk of double-counting.data/consolidated/all_prs.json (1)
17187-17193: MissingmergedAttimestamp and staleupdatedAtfor merged PR entryThe PR is now marked
"state": "MERGED"but the object still lacks amergedAt(orclosedAt) field, and theupdatedAtvalue is months old. Down-stream reports that rely on these timestamps (e.g., lead-time or cycle-time metrics) will silently under-report."updatedAt": "2025-02-14T15:11:26Z", + "mergedAt": "2025-07-11T06:43:48Z",Please regenerate or patch the record so that
updatedAt≥mergedAtand both reflect the actual merge event.data/consolidated/failing_prs.json (1)
5248-5260: Timestamp & URL update looks consistent – no issues spotted.
startedAtprecedescompletedAt, and the Jenkins build number (/4/) is consistently reflected in bothtargetUrlanddetailsUrl.
No structural or data-quality concerns on this hunk.data/consolidated/open_prs.json (1)
12257-12268: Chronology betweenStatusContextandCheckRunlooks inverted – please double-check the timestamps
StatusContext.startedAtis2025-07-11T06:43:48Z, while the correspondingCheckRunreportscompletedAtas2025-07-11T06:43:47Z(one second earlier).
Although this may simply reflect the order in which GitHub recorded events, it can trip up consumers that assume a status context starts before or during the run it describes.Please confirm these timestamps are correct in the source data (and in the sibling JSON files updated by the job).
If they are accurate, no action is required; otherwise regenerate the snapshot.junit5_candidate_prs.txt (2)
1-1: Header timestamp correctly refreshed
No issues – the header now reflects the 2025-07-12 collection run.
16-18: Entries merely re-ordered / uncommented – looks good
All touched records keep the same semantics (repository, PR URL, status) – only the ordering/comment state changed. No structural or content errors spotted.Also applies to: 40-42, 52-54, 82-84, 127-129, 136-138, 157-159, 220-222, 256-258, 442-444, 484-486, 571-573, 703-705, 709-711, 808-810, 895-897, 877-879
| "url": "https://github.com/jenkinsci/ssh-agents-plugin/pull/605", | ||
| "repository": "jenkinsci/ssh-agents-plugin", | ||
| "state": "MERGED", | ||
| "author": "strangelookingnerd", | ||
| "labels": null, | ||
| "body": "This amends #562.\nApparently docker-fixtures is no longer being maintained. Turns out it was not required for this test in the first place, allowing a clean migration to JUnit5.\n\nMigrate annotations and imports\nMigrate assertions\nRemove public visibility for test classes and methods\nRemove docker-fixtures\nMinor code cleanup\n\nTesting done\nmvn clean verify\nSubmitter checklist\n\n Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!\n Ensure that the pull request title represents the desired changelog entry\n Please describe what you did\n Link to relevant issues in GitHub or Jira\n Link to relevant pull requests, esp. upstream and downstream changes\n Ensure you have provided tests that demonstrate the feature works or the issue is fixed", | ||
| "createdAt": "2025-07-08T06:57:18Z" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Non-standard state value
"MERGED" is not part of the GitHub v4/v5 API enum (OPEN | CLOSED).
Either keep a separate boolean (merged: true) or record the merged-at timestamp and rely on state == "CLOSED".
- "state": "MERGED",
+ "state": "CLOSED",
+ "mergedAt": "2025-07-09T00:00:00Z"Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In data/junit5/junit5_candidates.json around lines 733 to 739, the "state" field
uses a non-standard value "MERGED" which is not part of the GitHub API enum that
only allows "OPEN" or "CLOSED". To fix this, change the "state" value to
"CLOSED" and add a separate boolean field like "merged": true or include the
merged timestamp to indicate the merged status explicitly.
| { | ||
| "__typename": "StatusContext", | ||
| "context": "continuous-integration/jenkins/pr-head", | ||
| "startedAt": "2025-03-29T11:35:15Z", | ||
| "startedAt": "2025-07-11T06:43:48Z", | ||
| "state": "ERROR", | ||
| "targetUrl": "https://ci.jenkins.io/job/Plugins/job/qy-wechat-notification-plugin/job/PR-13/1/display/redirect" | ||
| "targetUrl": "https://ci.jenkins.io/job/Plugins/job/qy-wechat-notification-plugin/job/PR-13/4/display/redirect" | ||
| }, | ||
| { | ||
| "__typename": "CheckRun", | ||
| "completedAt": "2025-03-29T11:35:15Z", | ||
| "completedAt": "2025-07-11T06:43:47Z", | ||
| "conclusion": "FAILURE", | ||
| "detailsUrl": "https://ci.jenkins.io/job/Plugins/job/qy-wechat-notification-plugin/job/PR-13/1/display/redirect", | ||
| "detailsUrl": "https://ci.jenkins.io/job/Plugins/job/qy-wechat-notification-plugin/job/PR-13/4/display/redirect", | ||
| "name": "Jenkins", | ||
| "startedAt": "2025-03-29T11:34:53Z", | ||
| "startedAt": "2025-07-11T06:43:22Z", | ||
| "status": "COMPLETED", | ||
| "workflowName": "" | ||
| } |
There was a problem hiding this comment.
Jenkins URLs reference “PR-13” while entry pertains to PR #11 – check data source
All Jenkins URLs inside this status block point at
…/job/qy-wechat-notification-plugin/job/PR-13/4/…, yet the surrounding record describes PR #11.
Unless the plugin repository renumbered PRs independently (unlikely), this indicates that status details from a different PR were attached here, which will skew failure/health statistics.
Action:
- Verify the GraphQL collector isn’t stitching status contexts from the latest PR of the repo instead of the matching PR number.
- Re-run the collection for the affected day and purge the bad cache entry.
If confirmed, treat as a data-integrity bug – dashboards depending on this JSON will mis-flag the wrong PR.
🤖 Prompt for AI Agents
In data/consolidated/all_prs.json around lines 17354 to 17370, the Jenkins URLs
reference PR-13 while the record is for PR #11, indicating a mismatch likely
caused by the GraphQL collector attaching status from the wrong PR. Investigate
the data collection logic to ensure it matches status contexts to the correct PR
number rather than defaulting to the latest PR. After fixing the collector,
re-run the data collection for the affected day and clear any cached entries to
prevent corrupted data from affecting dashboards.
This PR contains automatically updated PR statistics data. Generated by GitHub Actions.
Summary by CodeRabbit