Skip to content

chore: .net publish script #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
olavloite wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: .net publish script #733

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0143fe3
chore: .net publish script
olavloite Jan 21, 2026
38b0274
Merge branch 'main' into publish-dotnet-wrapper
olavloite Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spannerlib/wrappers/spannerlib-dotnet/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# Remove existing packages to ensure that only the packages that are built in the next step will be pushed to nuget.
find ./**/bin/Release -type f -name "Alpha*.nupkg" -exec rm {} \;

dotnet build
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The dotnet build command here is redundant. The dotnet pack command on line 17 will automatically build the project if it hasn't been built or if changes have occurred. Additionally, the build.sh script is executed on line 10, which presumably already handles the build process. Removing this line will make the script slightly more efficient and less confusing.

# Pack and publish to nuget
dotnet pack
find ./**/bin/Release -type f -name "Alpha*.nupkg" -exec \
Expand Down
12 changes: 10 additions & 2 deletions ...wrappers/spannerlib-dotnet/spannerlib-dotnet-grpc-impl/spannerlib-dotnet-grpc-impl.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,21 @@
<Nullable>enable</Nullable>
<LangVersion>default</LangVersion>
<PackageId>Alpha.Google.Cloud.SpannerLib.GrpcImpl</PackageId>
<Version>1.0.0-alpha.20260119112406</Version>
<Version>1.0.0-alpha.20260120171456</Version>
<Authors>Google</Authors>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<RepositoryUrl>https://github.com/googleapis/go-sql-spanner</RepositoryUrl>
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Comment on lines +16 to 18
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 14. You can remove this conditional block to simplify the project file.


<ItemGroup>
<PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="All" Version="5.0.0.1" />
<PackageReference Include="Alpha.Google.Cloud.SpannerLib.GrpcServer" Version="1.0.0-alpha.20260119112406" />
<PackageReference Include="Alpha.Google.Cloud.SpannerLib.GrpcServer" Version="1.0.0-alpha.20260120171456" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup>
Expand Down
10 changes: 9 additions & 1 deletion ...pers/spannerlib-dotnet/spannerlib-dotnet-grpc-server/spannerlib-dotnet-grpc-server.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,19 @@
<PackageId>Alpha.Google.Cloud.SpannerLib.GrpcServer</PackageId>
<Title>SpannerLib Grpc Server</Title>
<Authors>Google</Authors>
<Version>1.0.0-alpha.20260119112406</Version>
<Version>1.0.0-alpha.20260120171456</Version>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<RepositoryUrl>https://github.com/googleapis/go-sql-spanner</RepositoryUrl>
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Comment on lines +17 to 19
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 15. You can remove this conditional block to simplify the project file.


<ItemGroup>
<PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="All" Version="5.0.0.1" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup>
Expand Down
11 changes: 10 additions & 1 deletion ...lib/wrappers/spannerlib-dotnet/spannerlib-dotnet-grpc-v1/spannerlib-dotnet-grpc-v1.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,22 @@
<Nullable>enable</Nullable>
<LangVersion>default</LangVersion>
<PackageId>Alpha.Google.Cloud.SpannerLib.Grpc.V1</PackageId>
<Version>1.0.0-alpha.20260119112406</Version>
<Version>1.0.0-alpha.20260120171456</Version>
<Authors>Google</Authors>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<RepositoryUrl>https://github.com/googleapis/go-sql-spanner</RepositoryUrl>
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Comment on lines +16 to +18
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 14. You can remove this conditional block to simplify the project file.


<ItemGroup>
<PackageReference Include="Google.Cloud.Spanner.V1" Version="5.8.0" />
<PackageReference Include="Google.Protobuf" Version="3.33.4" />
<PackageReference Include="Grpc.Net.Client" Version="2.71.0" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
</ItemGroup>

</Project>
10 changes: 9 additions & 1 deletion ...appers/spannerlib-dotnet/spannerlib-dotnet-mockserver/spannerlib-dotnet-mockserver.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,23 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<PackageId>Alpha.Google.Cloud.SpannerLib.MockServer</PackageId>
<Version>1.0.0-alpha.20260119112406</Version>
<Version>1.0.0-alpha.20260120171456</Version>
<Authors>Google</Authors>
<LangVersion>default</LangVersion>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<RepositoryUrl>https://github.com/googleapis/go-sql-spanner</RepositoryUrl>
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Comment on lines +17 to 19
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 15. You can remove this conditional block to simplify the project file.


<ItemGroup>
<PackageReference Include="Google.Cloud.Spanner.Admin.Database.V1" Version="5.8.0" />
<PackageReference Include="Google.Cloud.Spanner.V1" Version="5.8.0" />
<PackageReference Include="Grpc.AspNetCore.Server" Version="2.71.0" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
</ItemGroup>

</Project>
12 changes: 10 additions & 2 deletions ...pers/spannerlib-dotnet/spannerlib-dotnet-native-impl/spannerlib-dotnet-native-impl.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,15 @@
<Nullable>enable</Nullable>
<LangVersion>default</LangVersion>
<PackageId>Alpha.Google.Cloud.SpannerLib.NativeImpl</PackageId>
<Version>1.0.0-alpha.20260119112406</Version>
<Version>1.0.0-alpha.20260120171456</Version>
<Authors>Google</Authors>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<RepositoryUrl>https://github.com/googleapis/go-sql-spanner</RepositoryUrl>
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Comment on lines +16 to 18
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 14. You can remove this conditional block to simplify the project file.


<ItemGroup>
Expand All @@ -16,7 +23,8 @@

<ItemGroup>
<PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="All" Version="5.0.0.1" />
<PackageReference Include="Alpha.Google.Cloud.SpannerLib.Native" Version="1.0.0-alpha.20260119112406" />
<PackageReference Include="Alpha.Google.Cloud.SpannerLib.Native" Version="1.0.0-alpha.20260120171456" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
</ItemGroup>

</Project>
10 changes: 9 additions & 1 deletion ...erlib/wrappers/spannerlib-dotnet/spannerlib-dotnet-native/spannerlib-dotnet-native.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,19 @@
<PackageId>Alpha.Google.Cloud.SpannerLib.Native</PackageId>
<Title>.NET wrapper for the native SpannerLib shared library</Title>
<Authors>Google</Authors>
<Version>1.0.0-alpha.20260119112406</Version>
<Version>1.0.0-alpha.20260120171456</Version>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<RepositoryUrl>https://github.com/googleapis/go-sql-spanner</RepositoryUrl>
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Comment on lines +18 to 20
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 16. You can remove this conditional block to simplify the project file.


<ItemGroup>
<PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="All" Version="5.0.0.1" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
</ItemGroup>

<ItemGroup>
Expand Down
19 changes: 18 additions & 1 deletion spannerlib/wrappers/spannerlib-dotnet/spannerlib-dotnet/spannerlib-dotnet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,30 @@
<Nullable>enable</Nullable>
<LangVersion>default</LangVersion>
<PackageId>Alpha.Google.Cloud.SpannerLib</PackageId>
<Version>1.0.0-alpha.20260119112406</Version>
<Version>1.0.0-alpha.20260120171501</Version>
<PackageVersion>$(Version)</PackageVersion>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The <PackageVersion> property is redundant here. If not specified, PackageVersion defaults to the value of the <Version> property. You can safely remove this line to simplify the project file.

<DebugType>portable</DebugType>
<Authors>Google</Authors>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<RepositoryUrl>https://github.com/googleapis/go-sql-spanner</RepositoryUrl>
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
<Deterministic>true</Deterministic>
</PropertyGroup>

<PropertyGroup>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>

<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Comment on lines +25 to 27
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 16. You can remove this conditional block to simplify the project file.


<ItemGroup>
<PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="All" Version="5.0.0.1" />
<PackageReference Include="Google.Cloud.Spanner.V1" Version="5.8.0" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/>
</ItemGroup>

</Project>
Loading