Skip to content

Conversation

@olavloite
Copy link
Collaborator

Update package definitions to include source links.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating package versions and enhancing the .NET build and publish process. It integrates source link support for improved debugging and configures CI build settings for better integration with GitHub Actions. Additionally, the build script is updated to ensure the project is built before creating NuGet packages.

Highlights

  • Package Version Updates: The versions of several .NET packages have been updated to 1.0.0-alpha.20260120171456 or 1.0.0-alpha.20260120171501.
  • Source Link Integration: Added PublishRepositoryUrl, EmbedUntrackedSources, RepositoryUrl, and Microsoft.SourceLink.GitHub to enable source link support for better debugging.
  • CI Build Configuration: Added ContinuousIntegrationBuild property and conditional property group for GitHub Actions to improve CI integration.
  • Build Script Enhancement: The publish.sh script now includes a dotnet build command before packing, ensuring the project is built before creating NuGet packages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .NET projects to include SourceLink information for better debugging experiences with NuGet packages, and modifies the publishing script. The changes are generally good and align with modern .NET packaging practices. My review includes a few suggestions to remove some redundant code in the project files and the publish script to improve maintainability and efficiency.

# Remove existing packages to ensure that only the packages that are built in the next step will be pushed to nuget.
find ./**/bin/Release -type f -name "Alpha*.nupkg" -exec rm {} \;

dotnet build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The dotnet build command here is redundant. The dotnet pack command on line 17 will automatically build the project if it hasn't been built or if changes have occurred. Additionally, the build.sh script is executed on line 10, which presumably already handles the build process. Removing this line will make the script slightly more efficient and less confusing.

Comment on lines +16 to 18
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 14. You can remove this conditional block to simplify the project file.

Comment on lines +17 to 19
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 15. You can remove this conditional block to simplify the project file.

Comment on lines +16 to +18
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 14. You can remove this conditional block to simplify the project file.

Comment on lines +17 to 19
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 15. You can remove this conditional block to simplify the project file.

Comment on lines +16 to 18
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 14. You can remove this conditional block to simplify the project file.

Comment on lines +18 to 20
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 16. You can remove this conditional block to simplify the project file.

<PackageId>Alpha.Google.Cloud.SpannerLib</PackageId>
<Version>1.0.0-alpha.20260119112406</Version>
<Version>1.0.0-alpha.20260120171501</Version>
<PackageVersion>$(Version)</PackageVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The <PackageVersion> property is redundant here. If not specified, PackageVersion defaults to the value of the <Version> property. You can safely remove this line to simplify the project file.

Comment on lines +25 to 27
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
</PropertyGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PropertyGroup is redundant because <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild> is already set unconditionally on line 16. You can remove this conditional block to simplify the project file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant