feat: send string params as untyped values to Spanner #720
Conversation
Summary of ChangesHello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Spanner Go driver by modifying how string query parameters are processed. Instead of explicitly typing string parameters as Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature by sending string query parameters as untyped values, allowing Spanner to infer the column type. The implementation correctly handles various string types by converting them to spanner.GenericColumnValue, and the accompanying test updates in driver_with_mockserver_test.go effectively validate this new behavior. I have one suggestion in stmt.go to enhance completeness by handling an additional string type variant.
Send string query parameters as untyped string values to Spanner. This allows Spanner to infer the type of the column based on the database schema, instead of forcing Spanner to only accept the parameter if the corresponding column or expression is of a different type than STRING. This for example allows applications to use a generic string value to set a JSON, TIMESTAMP, DATE, NUMERIC, INT64 or any other value that is encoded as strings in Spanner.
olavloite
force-pushed
the
send-strings-as-untyped-values
branch
from
a8e1637 to
1bdf93f
Compare
| return v | ||
| } | ||
| if v == nil { | ||
| return spanner.GenericColumnValue{Value: structpb.NewNullValue()} |
There was a problem hiding this comment.
nit: we can have global or package-level NullValue and use that reused
var pbNull = structpb.NewNullValue()
spanner.GenericColumnValue{Value: pbNull}
There was a problem hiding this comment.
Yes, let me add that in a follow-up PR.
2 participants
Send string query parameters as untyped string values to Spanner. This allows Spanner to infer the type of the column based on the database schema, instead of forcing Spanner to only accept the parameter if the corresponding column or expression is of a different type than STRING.
This for example allows applications to use a generic string value to set a JSON, TIMESTAMP, DATE, NUMERIC, INT64 or any other value that is encoded as strings in Spanner.