Skip to content

Conversation

@olavloite
Copy link
Collaborator

Follow-up for #720

@olavloite olavloite requested a review from a team as a code owner January 12, 2026 06:38
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a micro-optimization by refactoring how null values are handled during parameter conversion. By creating and reusing a single, shared instance of structpb.NullValue, the change aims to reduce redundant object allocations and potentially improve memory efficiency within the go-sql-spanner driver.

Highlights

  • Shared NullValue Instance: A package-level variable nullValue has been introduced in stmt.go to hold a single, shared instance of structpb.NullValue.
  • Optimization in Parameter Conversion: The convertParam function in stmt.go has been updated to reuse this nullValue instance instead of creating a new structpb.NewNullValue() object each time a null parameter is encountered, reducing object allocation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@olavloite olavloite requested a review from bhatt4982 January 12, 2026 06:38
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a good optimization by using a single shared instance for structpb.NullValue. This is achieved by creating a package-level variable nullValue and using it to replace repeated calls to structpb.NewNullValue() within the convertParam function. This change effectively reduces memory allocations in a potentially hot path, improving performance. The implementation is correct, simple, and follows best practices for this kind of optimization. I have no further comments.

Copy link
Contributor

@bhatt4982 bhatt4982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite merged commit 75764e3 into main Jan 12, 2026
43 checks passed
@olavloite olavloite deleted the use-shared-null-value branch January 12, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants