Skip to content

Fix off-by-one in TruthFailureSubject.factValue. #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 19, 2026
Merged

Fix off-by-one in TruthFailureSubject.factValue. #1713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/com/google/common/truth/TruthFailureSubject.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ private StringSubject doFactValue(@Nullable String key, @Nullable Integer index)
fact("but contained multiple", factsWithName));
return ignoreCheck().that("");
}
if (index != null && index > factsWithName.size()) {
if (index != null && index >= factsWithName.size()) {
failWithoutActual(
fact("for key", key),
fact("index too high", index),
Expand Down
11 changes: 11 additions & 0 deletions core/src/test/java/com/google/common/truth/TruthFailureSubjectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,17 @@ public void factValueIntFailNotEnoughWithKey() {
assertFailureValue(e, "fact count was", "1");
}

@Test
public void factValueIntFailIndexEqualsCount() {
AssertionError e =
expectFailure(
whenTesting -> whenTesting.that(failure(fact("foo", "the foo"))).factValue("foo", 1));
assertFailureKeys(e, "for key", "index too high", "fact count was");
assertFailureValue(e, "for key", "foo");
assertFailureValue(e, "index too high", "1");
assertFailureValue(e, "fact count was", "1");
}

@Test
public void factValueIntFailNoValue() {
AssertionError e =
Expand Down
Loading