Repository navigation
Fix off-by-one in TruthFailureSubject.factValue. - #1713
Merged
Merged
Conversation
The "index too high" check only caught indices greater than the number of facts with that key, so an index exactly equal to the count fell through and blew up with `IndexOutOfBoundsException` when the code tried to fetch that fact. Fixes #1712 RELNOTES=n/a COPYBARA_INTEGRATE_REVIEW=#1712 from rootkiller6788:fix-truthfailure-factvalue-index-bounds b4dca51 PiperOrigin-RevId: 1002416678
copybara-service
Bot
force-pushed
the
test_1002358893
branch
from
October 19, 2026 17:07
92f8a39 to
16efe1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix off-by-one in
TruthFailureSubject.factValue.The "index too high" check only caught indices greater than the number of facts with that key, so an index exactly equal to the count fell through and blew up with
IndexOutOfBoundsExceptionwhen the code tried to fetch that fact.Fixes #1712
RELNOTES=n/a
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1712 from rootkiller6788:fix-truthfailure-factvalue-index-bounds b4dca51