Check for upload permission based on google group #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrace-google
force-pushed
the
acl_hack
branch
from
1f5e626 to
51d928a
Compare
| @@ -31,6 +32,15 @@ | |||
| ISSUETRACKER_WONTFIX_STATE = 'NOT_REPRODUCIBLE' | |||
|
|
|||
|
|
|||
| def has_vrp_upload_permission(reporter): | |||
There was a problem hiding this comment.
How often is this going to be called? Maybe we should cache this in redis?
There was a problem hiding this comment.
I was thinking of running the cron job every 5 min or so, but it should only need to be called when we have submissions, which would depend on the usage of it
but 1. good call - i was being stupid and calling it for each check, but i should update this to be at least just one call for each cron job run lol
and 2. redis sounds like also a good plan! ill do that in a separate CL -ive added a todo for me!!
There was a problem hiding this comment.
Redis probably not needed then. Thanks for fixing.
pgrace-google
force-pushed
the
acl_hack
branch
from
51d928a to
aa801c3
Compare
pgrace-google
force-pushed
the
acl_hack
branch
from
aa801c3 to
741353e
Compare
vitorguidi
added a commit
that referenced
this pull request
Jan 23, 2025
Merging #4562 to branch 'chrome' Co-authored-by: Vitor Guidi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the IssueTracker component create controls are locked down to this group, its possible for folks to accidentally migrate bugs into this component. To prevent that from happening, check for the reporter's membership before proceeding with the upload. It is a bit hacky i admit.