Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for upload permission based on google group #4625

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

pgrace-google
Copy link
Collaborator

Merging #4562 to branch 'chrome'

@pgrace-google
Copy link
Collaborator Author

basic tests failed in deploy.py - happy to fix it in this CL but that seems not right

@letitz
Copy link
Collaborator

letitz commented Jan 21, 2025

It's because of #4597, should be fixed by #4628.

@letitz
Copy link
Collaborator

letitz commented Jan 23, 2025

Should be fixed if you rebase.

Copy link
Collaborator

@vitorguidi vitorguidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vitorguidi vitorguidi merged commit 13787d5 into google:chrome Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants