feat: add humor.json with collection of jokes and poems#105
Open
google-labs-jules[bot] wants to merge 3 commits into
Open
feat: add humor.json with collection of jokes and poems#105google-labs-jules[bot] wants to merge 3 commits into
google-labs-jules[bot] wants to merge 3 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I have updated |
Author
|
I have updated |
mflaster
reviewed
Jun 25, 2026
| "punchline": "Because he was outstanding in his field." | ||
| }, | ||
| { | ||
| "joke": "What do you call fake spaghetti?", |
mflaster
reviewed
Jun 25, 2026
| "punchline": "An impasta." | ||
| }, | ||
| { | ||
| "joke": "Why don't skeletons fight each other?", |
mflaster
reviewed
Jun 25, 2026
| }, | ||
| { | ||
| "joke": "Why did the bicycle fall over?", | ||
| "punchline": "Because it was two-tired." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new file,
humor.json, located in the/appdirectory. This file serves as a structured data source containing a curated selection of jokes and poems.Why these changes were made
The primary goal was to centralize lighthearted content into a single, easily maintainable JSON file. By using a structured format, we allow the application to programmatically access and display these items (e.g., for a "Joke of the Day" feature or as placeholder content during development) without hardcoding strings directly into UI components.
Key Decisions
/appdirectory for easy access by frontend or backend services.typefield to distinguish between "joke" and "poem," ensuring the consuming logic can handle the display formatting differently if needed.author,category, orrating, can be added without breaking the existing structure.Content Structure Example
The file follows this general schema:
[ { "id": 1, "type": "joke", "setup": "Why did the programmer quit his job?", "punchline": "Because he didn't get arrays." }, { "id": 2, "type": "poem", "title": "Code in the Night", "lines": ["Lines of logic, deep and wide,", "Bugs have nowhere left to hide."] } ]