Skip to content

Exclude generated non-RefCounted objects from the tests #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qarmin merged 1 commit into from
Oct 5, 2026
Merged

Exclude generated non-RefCounted objects from the tests #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions AutomaticBugs/BasicData.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,15 @@ func check_if_is_allowed(method_data: Dictionary) -> bool:
if method_data["flags"] == method_data["flags"] | 128: # VARARG TODO, Godot issue, add missing flag binding
return false

# If the function returns a new Object/Node (or other non-RefCounted Object subtype)
# that isn't already part of the scene tree, there's nobody to free it, since we just
# discard the return value below. RefCounted returns are fine, they free themselves.
var return_class_name: String = method_data["return"]["class_name"]
if !return_class_name.is_empty() && !ClassDB.is_parent_class(return_class_name, "RefCounted"):
var method_name: String = method_data["name"]
if method_name.contains("generate"):
return false

for arg in method_data["args"]:
var name_of_class: String = arg["class_name"]
if name_of_class in disabled_classes:
Expand Down
Loading