Skip to content

Exclude generated non-RefCounted objects from the tests - #86

Merged
qarmin merged 1 commit into
godotengine:4.0from
aaronfranke:exclude-generated-objects
Oct 5, 2026
Merged

qarmin merged 1 commit into
godotengine:4.0from
aaronfranke:exclude-generated-objects

Conversation

@aaronfranke

Copy link
Copy Markdown
Member

This PR excludes functions from the regression test project when both of these are true:

  • The function returns a non-RefCounted Object type, such as Node-derived classes.
  • The function name contains the word "generate".

The intention here is to exclude objects that are intentionally owned by the function caller, otherwise the regression test project step reports calls to those functions as memory leaks when Godot exits.

Example of a failing CI run: https://github.com/godot-dimensions/godot/actions/runs/33378365263/job/99444996137

Example of a passing CI run, where the only change compared to the failing run is pointing the CI at this branch: https://github.com/godot-dimensions/godot/actions/runs/33413334316/job/99561138386

@qarmin qarmin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-20.04 ci image needs to be updated to fix freezes in CI

@qarmin
qarmin merged commit 54758e0 into godotengine:4.0 Oct 5, 2026
1 check failed
@aaronfranke
aaronfranke deleted the exclude-generated-objects branch October 5, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants