Repository navigation
Exclude generated non-RefCounted objects from the tests - #86
Merged
Merged
Conversation
qarmin
approved these changes
Aug 31, 2026
qarmin
left a comment
Collaborator
There was a problem hiding this comment.
ubuntu-20.04 ci image needs to be updated to fix freezes in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR excludes functions from the regression test project when both of these are true:
The intention here is to exclude objects that are intentionally owned by the function caller, otherwise the regression test project step reports calls to those functions as memory leaks when Godot exits.
Example of a failing CI run: https://github.com/godot-dimensions/godot/actions/runs/33378365263/job/99444996137
Example of a passing CI run, where the only change compared to the failing run is pointing the CI at this branch: https://github.com/godot-dimensions/godot/actions/runs/33413334316/job/99561138386