Skip to content

Migrate to SAF for file access - #12

Merged
m4gr3d merged 1 commit into
godotengine:mainfrom
syntaxerror247:saf-support
Feb 23, 2026
Merged

m4gr3d merged 1 commit into
godotengine:mainfrom
syntaxerror247:saf-support

Conversation

@syntaxerror247

@syntaxerror247 syntaxerror247 commented Feb 12, 2026 •

Copy link
Copy Markdown
Member

This PR migrates storage access to SAF and removes the MANAGE_EXTERNAL_STORAGE permission.

The implementation is still in progress (code is still a mess and I need to move utils methods to seperate file etc.). I just created this PR so you guys can properly test the workflow. Feedback is welcome.
You can test it using the GHA artifacts for this PR.

For testing release builds, either:

Debug builds work without any additional steps.

@syntaxerror247
syntaxerror247 force-pushed the saf-support branch 3 times, most recently from 15dad84 to 96802a8 Compare February 14, 2026 12:46
@syntaxerror247 syntaxerror247 added this to the 1.0.0 milestone Feb 17, 2026
@syntaxerror247
syntaxerror247 force-pushed the saf-support branch 3 times, most recently from 361ee55 to cc2fa4e Compare February 17, 2026 20:41
@syntaxerror247 syntaxerror247 changed the title [WIP] Transition to SAF for file access Migrate to SAF for file access Feb 17, 2026
@syntaxerror247
syntaxerror247 marked this pull request as ready for review February 17, 2026 21:36
@syntaxerror247
syntaxerror247 marked this pull request as draft February 17, 2026 21:42
@syntaxerror247

syntaxerror247 commented Feb 17, 2026 •

Copy link
Copy Markdown
Member Author

Converting this back to draft. I need to add a dialog that explains to users why the notification permission is required, and add support for custom gradle_build_directory.

@syntaxerror247
syntaxerror247 force-pushed the saf-support branch 3 times, most recently from 0643ca6 to 834cafd Compare February 18, 2026 20:57
@syntaxerror247

syntaxerror247 commented Feb 18, 2026 •

Copy link
Copy Markdown
Member Author

Converting this back to draft. I need to add a dialog that explains to users why the notification permission is required, and add support for custom gradle_build_directory.

Done!

Restored support for a custom gradle_build_directory. The project card now also displays the Gradle build directory, to make it clear which entry belongs to which gradle project.

Added a dialog explaining why notification permission is required.

@syntaxerror247
syntaxerror247 marked this pull request as ready for review February 18, 2026 20:59
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/FileUtils.kt Outdated
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/MainActivity.kt Outdated
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/MainActivity.kt Outdated
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/MainActivity.kt Outdated
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/MainActivity.kt Outdated
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/MainActivity.kt Outdated
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/Utils.kt Outdated
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/Utils.kt Outdated
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/Utils.kt Outdated
Comment thread app/src/main/java/org/godotengine/godot_gradle_build_environment/FileUtils.kt Outdated
Comment thread app/src/main/res/values/strings.xml Outdated
@syntaxerror247

Copy link
Copy Markdown
Member Author

@m4gr3d Thanks for reviews, I've resolved all your comments.

@m4gr3d m4gr3d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job!

@m4gr3d
m4gr3d merged commit 30f151a into godotengine:main Feb 23, 2026
1 check passed
@syntaxerror247
syntaxerror247 deleted the saf-support branch February 23, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants