Repository navigation
Restore Full Storage Access for XR devices - #22
Conversation
| } | ||
| horizonos { | ||
| dimension "android_distribution" | ||
| applicationIdSuffix ".horizonos" |
There was a problem hiding this comment.
If we want to add this suffix then we'd also need to add logic to detect the OS here https://github.com/godotengine/godot/blob/caf16709af9f08bb430ddb8cffc10cbf66c62437/platform/android/java/editor/src/main/java/org/godotengine/editor/buildprovider/GradleBuildEnvironmentClient.kt#L113-L114
But this would break the backward compatibility.
I think it's fine to ommit the applicationIdSuffix, we have versionNameSuffix to differenciate between builds.
There was a problem hiding this comment.
This makes sense to me! I don't think we want to have to synchronize platform specific ids between Godot and GABE
syntaxerror247
changed the title
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
I tested this on Meta Quest 3 and it seems to work with Godot 4.6 from the Horizon store!
(I did hit an error in the Gradle build about it being unable to connect to "services.gradle.org", but it succeeded in copying the Gradle files from the project, so for the purposes of this PR, I think it's working. I'll keep poking at it and see if I can get it actually building, but I don't want to hold this up)
0fa4828 to
f206454
Compare
It was due to an error during copying file after rootfs download (regression from #10) @dsnopek Can you test again? Make sure to delete the rootfs and re-download. |
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks! I was able to complete a build on HorizonOS with the latest change :-)
|
I also tested this on the Pico 4 Ultra, and it fixes the issues there as well. |
2 participants
This PR restores the MANAGE_EXTERNAL_STORAGE logic on XR devices (picoOS and horizonOS) to fix the issue caused after migration to SAF because notification isn't being triggered on these devices.