Don't attempt to extract a URL from invalid coordinates (-1,-1) #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the terminal context menu is opened from a session titlebar, the coordinates passed to
menuAtCoord:(VT100GridCoord)coord
are (-1,-1), of which the y-coordinate is used as an array index to extract a line from the terminal grid in order to extract a URL. This causes a crash due to a[-1]
array index downstream ingetLineAtIndex:(int)theIndex
as the context menu is being built when left-clicking the session titlebar context menu button in all versions after 2534252 with the following message:This PR adds a lower bounds check on the coordinates before attempting to retrieve the line and extract the URL.