Don't attempt to extract a URL from invalid coordinates (-1,-1) if co…

…ntext menu is opened from the session titlebar (#434)
gnachman · Jan 25, 2021 · b2ab082 · b2ab082
1 parent 7102048
commit b2ab082
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/sources/iTermTextViewContextMenuHelper.m b/sources/iTermTextViewContextMenuHelper.m
@@ -361,14 +361,18 @@ - (NSMenu *)menuAtCoord:(VT100GridCoord)coord {
                                                                  @"Context menu")
                      action:@selector(copy:) keyEquivalent:@""];
 
-    iTermTextExtractor *extractor = [self.delegate contextMenuTextExtractor:self];
-    NSString *urlID;
-    NSURL *url = [extractor urlOfHypertextLinkAt:coord urlId:&urlID];
-    if (url) {
-        NSMenuItem *item = [theMenu addItemWithTitle:@"Copy Link Address" action:@selector(copyLinkAddress:) keyEquivalent:@""];
-        item.target = self;
-        item.representedObject = url;
+    // Don't attempt to extract a URL from invalid coordinates (-1,-1) if opened from the session titlebar
+    if (coord.x >= 0 && coord.y >= 0) {
+        iTermTextExtractor *extractor = [self.delegate contextMenuTextExtractor:self];
+        NSString *urlID;
+        NSURL *url = [extractor urlOfHypertextLinkAt:coord urlId:&urlID];
+        if (url) {
+            NSMenuItem *item = [theMenu addItemWithTitle:@"Copy Link Address" action:@selector(copyLinkAddress:) keyEquivalent:@""];
+            item.target = self;
+            item.representedObject = url;
+        }
     }
+
     [theMenu addItemWithTitle:NSLocalizedStringFromTableInBundle(@"Paste",
                                                                  @"iTerm",
                                                                  [NSBundle bundleForClass: [self class]],