feat: provide bincode serde#76
Conversation
| >(&ctx.get_request_body()) { | ||
| Ok(res) => Ok(res), | ||
| // deserialize from bincode | ||
| match bincode::decode_from_slice(&ctx.get_response_body(), bincode::config::standard()) { |
There was a problem hiding this comment.
I see you keep avoiding ProxyHandler::parse_request_body (or pingora-router utils), what's your reason?
There was a problem hiding this comment.
The init handshake still uses json
There was a problem hiding this comment.
The init handshake still uses json
is it related to my above question?
There was a problem hiding this comment.
Ok, I'll get the bincode into the utils
There was a problem hiding this comment.
You alluded to us having that conversation/ticket later
There was a problem hiding this comment.
You alluded to us having that conversation/ticket later
Haha, yeah. But I’m honestly curious about your reason for not using the utils? If you feel a utility should be removed because it’s unnecessary, it’s important to look at its usages and the original purpose behind it.
|
still buggy, have you tested ? 
|
|
I'm having an error when testing the whole flow I suspect configs I have; I'm using .env.dev for the proxies and ran |
try to use |
ah, sorry, misread, show me your reverse-proyx env, the ntor server ID should look like this |
|
@dtpthao The flow should now work |
dtpthao
left a comment
dtpthao
left a comment
There was a problem hiding this comment.
Update ntor import and interceptor import in spa-frontend, reverse-proxy version and you can merge it
| once_cell = "1.21.3" | ||
| dotenv = "0.15.0" | ||
| ntor = { git = "https://github.com/globe-and-citizen/ntor.git", tag = "0.1.1" } | ||
| ntor = { git = "https://github.com/globe-and-citizen/ntor.git", branch = "feat/provide-bincode-serde"} |
2 participants
Changes:
ntor::EncryptedType