Switch from `serde_json` to `bincode` for serialization

[dtpthao]

Description: We've successfully moved from the implementation phase to stabilization. During this phase, we need to keep changes narrowly focused to minimize the risk of regressions. Please revert any out-of-scope updates in your PRs and keep them limited to the dependency switch.

Acceptance criteria:

• Update serialization utility functions in layer8-interceptor-production to use bincode crate.
• Update serialization utility functions in layer8-backbone to use bincode crate.
• For any usage of serde_json outside a utility function, replace it with a call to the appropriate utility function.

I appreciate that you identified some syntax issues—feel free to create separate issues for each improvement idea, explain them, and we’ll discuss them.

[muse254]

Related PRs:

• feat: provide bincode serde #76
• feat: provide bincode serde ntor#9
• refactor: use bincode for EncryptedMessage layer8-interceptor-production#13

[dtpthao]

Related PRs:

• feat: provide bincode serde #76
• feat: provide bincode serde ntor#9
• refactor: use bincode for EncryptedMessage layer8-interceptor-production#13

It's still buggy for me

[muse254]

On it

[dtpthao]

On it

Just imagine how many places this dependency will be used. It handles both serialization and deserialization for every request:

• How many request types do we support? (/init-tunnel, /proxy, /healthcheck?)

• How many services does each request pass through? (Interceptor, FP, RP)

• And it will likely be used even more heavily in the RP than in the other services?

[muse254]

We could create a method call for each type if it comes to it, generalising things in common Trait impl is my main issue tbh
I don't feel there's a place for traits in these implementations, we're zigzagging through implementations to understand whats happening

[dtpthao]

We could create a method call for each type if it comes to it, generalising things in common Trait impl is my main issue tbh I don't feel there's a place for traits in these implementations, we're zigzagging through implementations to understand whats happening

So you’re suggesting we duplicate the same operation for every type? I don't agree with that — it goes against the DRY principle

[muse254]

It's just two types and right now one uses json and the other bincode, so different implementations
The traits are meant for external APIs anyway, internally no one needs compliance since we have private access

[dtpthao]

It's just two types and right now one uses json and the other bincode, so different implementations The traits are meant for external APIs anyway, internally no one needs compliance since we have private access

you might have forgotten the 3rd type, ErrorResponse — unless you actually want to remove it. I suggest not touching it, since I don’t recall all its usages and changing it could be risky. You have two options:

• Use trait — this way, you only need to fix 2 functions instead of adding them separately to all three types.

• Create 2 utility functions for serialization and deserialization (we already have them?) and call those inside the handling functions.

[dtpthao]

It's just two types and right now one uses json and the other bincode, so different implementations The traits are meant for external APIs anyway, internally no one needs compliance since we have private access

you might have forgotten the 3rd type, ErrorResponse — unless you actually want to remove it. I suggest not touching it, since I don’t recall all its usages and changing it could be risky. You have two options:

• Use trait — this way, you only need to fix 2 functions instead of adding them separately to all three types.
• Create 2 utility functions for serialization and deserialization (we already have them?) and call those inside the handling functions.

my mistake, ErrorResponse is not an equivalent of the other 2 types, serde_json is still in use in many places, I need to recheck this

[muse254]

The updates have been merged and the new npm version deployed: https://www.npmjs.com/package/layer8-interceptor-production?activeTab=versions